hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14703) HTable.mutateRow does not collect stats
Date Thu, 24 Mar 2016 09:32:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209994#comment-15209994
] 

Hudson commented on HBASE-14703:
--------------------------------

FAILURE: Integrated in HBase-1.3 #621 (See [https://builds.apache.org/job/HBase-1.3/621/])
HBASE-14703 HTable.mutateRow does not collect stats (Heng Chen) (chenheng: rev c10afab6c1a4c7d7dd66f2b0acff799d036452b5)
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestCheckAndMutate.java
* hbase-protocol/src/main/protobuf/Client.proto
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatsTrackingRpcRetryingCaller.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncProcess.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ResponseConverter.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/StatisticTrackable.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RSRpcServices.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/RetryingTimeTracker.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/ResultStatsUtil.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
* hbase-protocol/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ClientProtos.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/PayloadCarryingServerCallable.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/ServerStatisticTracker.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiResponse.java
* hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestAsyncProcess.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestReplicasClient.java
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/MultiServerCallable.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestClientPushback.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


> HTable.mutateRow does not collect stats
> ---------------------------------------
>
>                 Key: HBASE-14703
>                 URL: https://issues.apache.org/jira/browse/HBASE-14703
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>            Reporter: Heng Chen
>            Assignee: Heng Chen
>             Fix For: 2.0.0, 1.3.0, 1.4.0
>
>         Attachments: HBASE-14702_v5.2_addendum-addendum.patch, HBASE-14703-5.2-addendum.patch,
HBASE-14703-async.patch, HBASE-14703-branch-1.patch, HBASE-14703-branch-1.v1.patch, HBASE-14703-branch-1_v1.patch,
HBASE-14703-start.patch, HBASE-14703-v4.1.patch, HBASE-14703-v4.patch, HBASE-14703-v6_with-check-and-mutate.patch,
HBASE-14703.patch, HBASE-14703_v1.patch, HBASE-14703_v10.patch, HBASE-14703_v10.patch, HBASE-14703_v11.patch,
HBASE-14703_v12.patch, HBASE-14703_v13.patch, HBASE-14703_v2.patch, HBASE-14703_v3.patch,
HBASE-14703_v5.1.patch, HBASE-14703_v5.2.patch, HBASE-14703_v5.patch, HBASE-14703_v6-addendum.patch,
HBASE-14703_v6.patch, HBASE-14703_v7.patch, HBASE-14703_v8.patch, HBASE-14703_v9.patch
>
>
> We are trying to fix the stats implementation, by moving it out of the Result object
and into an Rpc payload (but not the 'cell payload', just as part of the values returned from
the request). This change will also us use easily switch to AsyncProcess as the executor,
and support stats, for nearly all the rpc calls. However, that means when you upgrade the
client or server, you will lose stats visibility until the other side is upgraded. We could
keep around the Result based stats storage to accommodate the old api and send both stats
back from the server (in each result and in the rpc payload).
> Note that we will still be wire compatible - protobufs mean we can just ride over the
lack of information.
> The other tricky part of this is that Result has a non-InterfaceAudience.Private getStatistics()
method (along with two InterfaceAudience.Private addResults and setStatistics methods), so
we might need a release to deprecate the getStats() method before throwing it out?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message