hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse Yates (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14703) HTable.mutateRow does not collect stats
Date Tue, 08 Mar 2016 03:10:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184306#comment-15184306

Jesse Yates commented on HBASE-14703:

And to be fair, there was a long, unresolved discussion on the dev list as to what _should_
be backported to branches. Some of the argument was in favor of bring more things back, some
of the argument was in favor of just bringing back bug fixes and keeping the improvements
(which can have their own bugs) off the 'stable' branch. Again, this didn't get resolved,
but doesn't help clarify project policies on this sort of stuff.

I'm just trying to help here, hence garnering discussion around where it should go, especially
as it is a kinda-sorta breaking change.

> HTable.mutateRow does not collect stats
> ---------------------------------------
>                 Key: HBASE-14703
>                 URL: https://issues.apache.org/jira/browse/HBASE-14703
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Heng Chen
>            Assignee: Heng Chen
>             Fix For: 2.0.0
>         Attachments: HBASE-14702_v5.2_addendum-addendum.patch, HBASE-14703-5.2-addendum.patch,
HBASE-14703-async.patch, HBASE-14703-start.patch, HBASE-14703-v4.1.patch, HBASE-14703-v4.patch,
HBASE-14703-v6_with-check-and-mutate.patch, HBASE-14703.patch, HBASE-14703_v1.patch, HBASE-14703_v10.patch,
HBASE-14703_v10.patch, HBASE-14703_v11.patch, HBASE-14703_v12.patch, HBASE-14703_v13.patch,
HBASE-14703_v2.patch, HBASE-14703_v3.patch, HBASE-14703_v5.1.patch, HBASE-14703_v5.2.patch,
HBASE-14703_v5.patch, HBASE-14703_v6-addendum.patch, HBASE-14703_v6.patch, HBASE-14703_v7.patch,
HBASE-14703_v8.patch, HBASE-14703_v9.patch
> We are trying to fix the stats implementation, by moving it out of the Result object
and into an Rpc payload (but not the 'cell payload', just as part of the values returned from
the request). This change will also us use easily switch to AsyncProcess as the executor,
and support stats, for nearly all the rpc calls. However, that means when you upgrade the
client or server, you will lose stats visibility until the other side is upgraded. We could
keep around the Result based stats storage to accommodate the old api and send both stats
back from the server (in each result and in the rpc payload).
> Note that we will still be wire compatible - protobufs mean we can just ride over the
lack of information.
> The other tricky part of this is that Result has a non-InterfaceAudience.Private getStatistics()
method (along with two InterfaceAudience.Private addResults and setStatistics methods), so
we might need a release to deprecate the getStats() method before throwing it out?

This message was sent by Atlassian JIRA

View raw message