hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14613) Remove MemStoreChunkPool?
Date Wed, 23 Mar 2016 02:46:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15207781#comment-15207781
] 

Anoop Sam John commented on HBASE-14613:
----------------------------------------

Thanks for sharing the details on what you see with MSLAB with G1GC.
But we are trying for off heap memstore (Off heap write path after the read path).   So there
will be MSLAB impl backed by off heap BBs.  Then we need a pool of BBs and reuse them. On
demand creation and throw away of DBBs may not be a good choice.  And also it is DBBs, the
actual size of the Java objects are small.   So we should not be removing this pool feature
IMO.

> Remove MemStoreChunkPool?
> -------------------------
>
>                 Key: HBASE-14613
>                 URL: https://issues.apache.org/jira/browse/HBASE-14613
>             Project: HBase
>          Issue Type: Brainstorming
>            Reporter: Lars Hofhansl
>            Priority: Minor
>         Attachments: 14613-0.98.txt, gc.png, writes.png
>
>
> I just stumbled across MemStoreChunkPool. The idea behind is to reuse chunks of allocations
rather than letting the GC handle this.
> Now, it's off by default, and it seems to me to be of dubious value. I'd recommend just
removing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message