hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14256) Flush task message may be confusing when region is recovered
Date Fri, 25 Mar 2016 01:22:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14256?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15211244#comment-15211244
] 

Hudson commented on HBASE-14256:
--------------------------------

FAILURE: Integrated in HBase-1.3 #623 (See [https://builds.apache.org/job/HBase-1.3/623/])
HBASE-14256 Flush task message may be confusing when region is recovered (jerryjch: rev ee7ac7ea3b6ffdf20e4d09defe18a7078eb3b29e)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java


> Flush task message may be confusing when region is recovered
> ------------------------------------------------------------
>
>                 Key: HBASE-14256
>                 URL: https://issues.apache.org/jira/browse/HBASE-14256
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>    Affects Versions: 2.0.0, 1.2.0
>            Reporter: Lars George
>            Assignee: Gabor Liptak
>              Labels: beginner
>             Fix For: 2.0.0, 1.3.0, 1.2.1, 1.4.0
>
>         Attachments: HBASE-14256.1.patch
>
>
> In {{HRegion.setRecovering()}} we have this code:
> {code}
>     // force a flush only if region replication is set up for this region. Otherwise
no need.
>       boolean forceFlush = getTableDesc().getRegionReplication() > 1;
>       // force a flush first
>       MonitoredTask status = TaskMonitor.get().createStatus(
>         "Flushing region " + this + " because recovery is finished");
>       try {
>         if (forceFlush) {
>           internalFlushcache(status);
>         }
> {code}
> So we only optionally force flush after a recovery of a region, but the message always
is set to "Flushing...", which might be confusing. We should change the message based on {{forceFlush}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message