hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Geoffrey Jacoby (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-11393) Replication TableCfs should be a PB object rather than a string
Date Wed, 30 Mar 2016 20:52:25 GMT

    [ https://issues.apache.org/jira/browse/HBASE-11393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218837#comment-15218837
] 

Geoffrey Jacoby commented on HBASE-11393:
-----------------------------------------

Thanks for this [~chenheng]; the tracker on the replication peer config is already proving
useful. 

Has the decision been made to remove "add_peer peer_id, cluster_key" from the Ruby shell in
addition to the equivalent methods on ReplicationAdmin, as this JIRA does? While the ReplicationAdmin
methods are marked as Deprecated in 1.0, and thus seem fair game to remove in 2.0, the Ruby
method that takes a string rather than a dictionary is still the "official" way to create
a peer in the HBase shell in the HBase book on hbase.apache.org. If nothing else the doc should
probably be updated. 

Its removal as part of this JIRA is also breaking TestReplicationShell (currently set as Ignore
because it was apparently flaky in the past), but which I've been using locally to verify
some shell changes I'm working on for HBASE-15507. I can fix the test, but want to confirm
that it's the test that needs to change. 

> Replication TableCfs should be a PB object rather than a string
> ---------------------------------------------------------------
>
>                 Key: HBASE-11393
>                 URL: https://issues.apache.org/jira/browse/HBASE-11393
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Enis Soztutar
>            Assignee: Heng Chen
>             Fix For: 2.0.0
>
>         Attachments: HBASE-11393.patch, HBASE-11393_v1.patch, HBASE-11393_v10.patch,
HBASE-11393_v11.patch, HBASE-11393_v12.patch, HBASE-11393_v14.patch, HBASE-11393_v15.patch,
HBASE-11393_v16.patch, HBASE-11393_v2.patch, HBASE-11393_v3.patch, HBASE-11393_v4.patch, HBASE-11393_v5.patch,
HBASE-11393_v6.patch, HBASE-11393_v7.patch, HBASE-11393_v8.patch, HBASE-11393_v9.patch
>
>
> We concatenate the list of tables and column families in format  "table1:cf1,cf2;table2:cfA,cfB"
in zookeeper for table-cf to replication peer mapping. 
> This results in ugly parsing code. We should do this a PB object. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message