Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4057018C27 for ; Thu, 25 Feb 2016 06:35:17 +0000 (UTC) Received: (qmail 46820 invoked by uid 500); 25 Feb 2016 06:34:18 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 46705 invoked by uid 500); 25 Feb 2016 06:34:18 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 46495 invoked by uid 99); 25 Feb 2016 06:34:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Feb 2016 06:34:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 65D992C1F68 for ; Thu, 25 Feb 2016 06:34:18 +0000 (UTC) Date: Thu, 25 Feb 2016 06:34:18 +0000 (UTC) From: "Yu Li (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15324) Jitter may cause desiredMaxFileSize overflow in ConstantSizeRegionSplitPolicy and trigger unexpected split MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15166812#comment-15166812 ] Yu Li commented on HBASE-15324: ------------------------------- Another thing I'd like to mention is that currently there's no attribute in HTableDescriptor to mark a table not splittable, and we have to achieve this by specifying MAX_FILESIZE to Long.MAX_VALUE. I think we could introduce a new attribute like NEVER_SPLIT to make it much easier and straight-forward. Thoughts on this idea? If agreed, I could open another JIRA to implement it. Thanks. > Jitter may cause desiredMaxFileSize overflow in ConstantSizeRegionSplitPolicy and trigger unexpected split > ---------------------------------------------------------------------------------------------------------- > > Key: HBASE-15324 > URL: https://issues.apache.org/jira/browse/HBASE-15324 > Project: HBase > Issue Type: Bug > Affects Versions: 2.0.0, 1.1.3 > Reporter: Yu Li > Assignee: Yu Li > Attachments: HBASE-15324.patch > > > We introduce jitter for region split decision in HBASE-13412, but the following line in {{ConstantSizeRegionSplitPolicy}} may cause long value overflow if MAX_FILESIZE is specified to Long.MAX_VALUE: > {code} > this.desiredMaxFileSize += (long)(desiredMaxFileSize * (RANDOM.nextFloat() - 0.5D) * jitter); > {code} > In our case we specify MAX_FILESIZE to Long.MAX_VALUE to prevent target region to split. -- This message was sent by Atlassian JIRA (v6.3.4#6332)