Return-Path: 
 <issues-return-232897-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id B7CD11870C
	for <apmail-hbase-issues-archive@www.apache.org>;
 Thu, 25 Feb 2016 03:41:19 +0000 (UTC)
Received: (qmail 8724 invoked by uid 500); 25 Feb 2016 03:41:18 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 8636 invoked by uid 500); 25 Feb 2016 03:41:18 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 8147 invoked by uid 99); 25 Feb 2016 03:41:18 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 25 Feb 2016 03:41:18 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 49A472C1F6E
	for <issues@hbase.apache.org>; Thu, 25 Feb 2016 03:41:18 +0000 (UTC)
Date: Thu, 25 Feb 2016 03:41:18 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12941627.1456284897000.141304.1456371678299@Atlassian.JIRA>
In-Reply-To: <JIRA.12941627.1456284897000@Atlassian.JIRA>
References: <JIRA.12941627.1456284897000@Atlassian.JIRA>
 <JIRA.12941627.1456284897454@arcas>
Subject: [jira] [Commented] (HBASE-15319) clearJmxCache does not take effect
 actually
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-15319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15166674#comment-15166674 ] 

Hudson commented on HBASE-15319:
--------------------------------

SUCCESS: Integrated in HBase-1.3-IT #515 (See [https://builds.apache.org/job/HBase-1.3-IT/515/])
HBASE-15319 clearJmxCache does not take effect actually (eclark: rev 13773254c87994c6cffdb3fbc48521d51c86d8c5)
* hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/impl/JmxCacheBuster.java


> clearJmxCache does not take effect actually
> -------------------------------------------
>
>                 Key: HBASE-15319
>                 URL: https://issues.apache.org/jira/browse/HBASE-15319
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 2.0.0, 1.2.0, 1.1.0.1, 1.3.0
>            Reporter: Hao Lin
>            Assignee: Elliott Clark
>              Labels: easyfix
>             Fix For: 2.0.0, 1.3.0, 1.2.1
>
>         Attachments: HBASE-15319.patch
>
>
> When trying to backport HBASE-14166 to 0.98.6, I find JmxCacheBuster::clearJmxCache() does no take effect actually. The related code are listed below:
> {code:title=org.apache.hadoop.metrics2.impl.JmxCacheBuster.java|borderStyle=solid}
> // fut is initialized to null
> private static AtomicReference<ScheduledFuture> fut = new AtomicReference<>(null);
> public static void clearJmxCache() {
>     // clearJmxCache return directly when fut is null, which is always true.
>     // the actual intent is 'if (future != null && !future.isDone ...)' ?
>     ScheduledFuture future = fut.get();
>     if ((future == null || (!future.isDone() && future.getDelay(TimeUnit.MILLISECONDS) > 100))) {
>       return;
>     }
>     ......
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)