Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id B00A618EB7 for ; Fri, 19 Feb 2016 20:06:18 +0000 (UTC) Received: (qmail 49736 invoked by uid 500); 19 Feb 2016 20:06:18 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 49671 invoked by uid 500); 19 Feb 2016 20:06:18 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 49654 invoked by uid 99); 19 Feb 2016 20:06:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Feb 2016 20:06:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 2F5A22C1F57 for ; Fri, 19 Feb 2016 20:06:18 +0000 (UTC) Date: Fri, 19 Feb 2016 20:06:18 +0000 (UTC) From: "huaxiang sun (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15261) Make Throwable t in DaughterOpener volatile MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154785#comment-15154785 ] huaxiang sun commented on HBASE-15261: -------------------------------------- Hi [~tedyu@apache.org], just a followup with this issue. We looked into the possible causes for the exception. We identified two possible causes. 1. If a table is added without any column families, this is not the case as we verified that with the user. 2. This current one. As in the split process, openning daughter regions are handled by two separate threads. The main thread will check the exception set by two child-region-open threads and go ahead to add these regions into onlineRegions map. It is possible that the main thread will miss the exception since it is not declared as volatile and add the region to onlineRegions map. Thanks > Make Throwable t in DaughterOpener volatile > ------------------------------------------- > > Key: HBASE-15261 > URL: https://issues.apache.org/jira/browse/HBASE-15261 > Project: HBase > Issue Type: Bug > Components: regionserver > Reporter: huaxiang sun > Assignee: huaxiang sun > Priority: Minor > Attachments: HBASE-15261-001.patch > > > In the region split process, daughter regions are opened in different threads, Throwable t is set in these threads and it is checked in the calling thread. Need to make it volatile so the checking will not miss any exceptions from opening daughter regions. -- This message was sent by Atlassian JIRA (v6.3.4#6332)