Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 067BE18DD1 for ; Wed, 10 Feb 2016 18:32:19 +0000 (UTC) Received: (qmail 39887 invoked by uid 500); 10 Feb 2016 18:32:18 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 39747 invoked by uid 500); 10 Feb 2016 18:32:18 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 39648 invoked by uid 99); 10 Feb 2016 18:32:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Feb 2016 18:32:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6AA172C1F5B for ; Wed, 10 Feb 2016 18:32:18 +0000 (UTC) Date: Wed, 10 Feb 2016 18:32:18 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-15229) Canary Tools should not call System.Exit on error MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-15229: ----------------------------------- Attachment: HBASE-15229-0.98.patch HBASE-15229.patch Attaching what I committed. > Canary Tools should not call System.Exit on error > ------------------------------------------------- > > Key: HBASE-15229 > URL: https://issues.apache.org/jira/browse/HBASE-15229 > Project: HBase > Issue Type: Bug > Components: canary > Affects Versions: 0.98.17 > Reporter: Vishal Khandelwal > Assignee: Vishal Khandelwal > Priority: Critical > Fix For: 2.0.0, 1.3.0, 1.2.1, 0.98.18 > > Attachments: HBASE-15229-0.98.patch, HBASE-15229.patch, HBASE-15229.v1.patch, HBASE-15229.v2.patch, HBASE-15229.v3.patch > > > run method in canary tool calls system.Exit on failure. Due to this it can't be integrated as an API as jvm will stop on failure. It should only return (exit code) > So any integration with unit test also fail with > {code} > [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.14:test (default-test) on project <>: Execution default-test of goal org.apache.maven.plugins:maven-surefire-plugin:2.14:test failed: The forked VM terminated without saying properly goodbye. VM crash or System.exit called ? > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)