hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Phil Yang (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15358) canEnforceTimeLimitFromScope should use timeScope instead of sizeScope
Date Mon, 29 Feb 2016 09:11:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171613#comment-15171613

Phil Yang commented on HBASE-15358:

final LimitScope sizeScope = allowPartialResults ? LimitScope.BETWEEN_CELLS : LimitScope.BETWEEN_ROWS;
final LimitScope timeScope = allowHeartbeatMessages ? LimitScope.BETWEEN_CELLS : LimitScope.BETWEEN_ROWS;
Because we supported HBASE-11544 before HBASE-13090, so there are three possible situations:
allow none, allow PartialResults but don't allow HeartbeatMessages, or allow both. So if a
client only support PartialResults, at canEnforceTimeLimitFromScope it may be return true
and may send back a wrong heartbeat which is not supported by client.

However, both  HBASE-11544 and HBASE-13090 are fixed on 1.1.0, so there are only two situations
in all released versions: allow both or none. So maybe it will not be a critical bug, actually
it has no bad effect on released versions...

I think if we want to add a testcase to reproduce this bug, we should disable allowHeartbeatMessages
which will not be disabled by users. Should we still add the testcase?

> canEnforceTimeLimitFromScope should use timeScope instead of sizeScope
> ----------------------------------------------------------------------
>                 Key: HBASE-15358
>                 URL: https://issues.apache.org/jira/browse/HBASE-15358
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.2.0, 1.1.3
>            Reporter: Phil Yang
>            Assignee: Phil Yang
>         Attachments: HBASE-15358-v1.txt
> A small but maybe critical bug

This message was sent by Atlassian JIRA

View raw message