hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15319) clearJmxCache does not take effect actually
Date Thu, 25 Feb 2016 06:20:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15166794#comment-15166794
] 

Hudson commented on HBASE-15319:
--------------------------------

SUCCESS: Integrated in HBase-1.2 #562 (See [https://builds.apache.org/job/HBase-1.2/562/])
HBASE-15319 clearJmxCache does not take effect actually (eclark: rev 4710463d2d7191425cc54ebe4d62e3f4ea6672dd)
* hbase-hadoop2-compat/src/main/java/org/apache/hadoop/metrics2/impl/JmxCacheBuster.java


> clearJmxCache does not take effect actually
> -------------------------------------------
>
>                 Key: HBASE-15319
>                 URL: https://issues.apache.org/jira/browse/HBASE-15319
>             Project: HBase
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 2.0.0, 1.2.0, 1.1.0.1, 1.3.0
>            Reporter: Hao Lin
>            Assignee: Elliott Clark
>              Labels: easyfix
>             Fix For: 2.0.0, 1.3.0, 1.2.1
>
>         Attachments: HBASE-15319.patch
>
>
> When trying to backport HBASE-14166 to 0.98.6, I find JmxCacheBuster::clearJmxCache()
does no take effect actually. The related code are listed below:
> {code:title=org.apache.hadoop.metrics2.impl.JmxCacheBuster.java|borderStyle=solid}
> // fut is initialized to null
> private static AtomicReference<ScheduledFuture> fut = new AtomicReference<>(null);
> public static void clearJmxCache() {
>     // clearJmxCache return directly when fut is null, which is always true.
>     // the actual intent is 'if (future != null && !future.isDone ...)' ?
>     ScheduledFuture future = fut.get();
>     if ((future == null || (!future.isDone() && future.getDelay(TimeUnit.MILLISECONDS)
> 100))) {
>       return;
>     }
>     ......
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message