hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15274) ClientSideRegionScanner's reaction to Scan#setBatch is not consistent between HBase versions
Date Wed, 17 Feb 2016 03:06:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149762#comment-15149762
] 

Hadoop QA commented on HBASE-15274:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue}
Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} |
{color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s {color} | {color:red}
The patch doesn't appear to include any new or modified tests. Please justify why no new tests
are needed for this patch. Also please list what manual steps were performed to verify this
patch. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 52s {color}
| {color:green} 0.98 passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s {color} |
{color:green} 0.98 passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 29s {color} |
{color:green} 0.98 passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 18s {color}
| {color:green} 0.98 passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 16s {color}
| {color:green} 0.98 passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 39s {color} | {color:red}
hbase-server in 0.98 has 84 extant Findbugs warnings. {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 28s {color} | {color:red}
hbase-server in 0.98 failed with JDK v1.8.0_72. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s {color} |
{color:green} 0.98 passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 35s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 27s {color} |
{color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 27s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s {color} |
{color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 30s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 14s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color}
| {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 3m 29s {color}
| {color:green} Patch does not cause any errors with Hadoop 2.4.1 2.5.2 2.6.0. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 53s {color} |
{color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} javadoc {color} | {color:red} 0m 22s {color} | {color:red}
hbase-server in the patch failed with JDK v1.8.0_72. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s {color} |
{color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 47m 22s {color} | {color:green}
hbase-server in the patch passed with JDK v1.8.0_72. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 50m 40s {color} | {color:green}
hbase-server in the patch passed with JDK v1.7.0_95. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 18s {color}
| {color:green} Patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 117m 1s {color} | {color:black}
{color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-17 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12788149/HBASE-15274-0.98.patch
|
| JIRA Issue | HBASE-15274 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  hbaseanti  checkstyle
 compile  |
| uname | Linux 749e61d83bf7 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12
UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/hbase.sh |
| git revision | 0.98 / c20d34c |
| findbugs | v2.0.1 |
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/561/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
|
| javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/561/artifact/patchprocess/branch-javadoc-hbase-server-jdk1.8.0_72.txt
|
| javadoc | https://builds.apache.org/job/PreCommit-HBASE-Build/561/artifact/patchprocess/patch-javadoc-hbase-server-jdk1.8.0_72.txt
|
| JDK v1.7.0_95  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/561/testReport/
|
| modules | C: hbase-server U: hbase-server |
| Max memory used | 107MB |
| Powered by | Apache Yetus 0.1.0   http://yetus.apache.org |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/561/console |


This message was automatically generated.



> ClientSideRegionScanner's reaction to Scan#setBatch is not consistent between HBase versions
> --------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15274
>                 URL: https://issues.apache.org/jira/browse/HBASE-15274
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.0.3, 1.1.3, 0.98.17
>            Reporter: Youngjoon Kim
>            Assignee: Youngjoon Kim
>            Priority: Minor
>         Attachments: HBASE-15274-0.98.patch, HBASE-15274-branch-1.0.patch
>
>
> In 1.1.3, ClientSideRegionScanner calls RegionScannerImpl#next() with single argument,
so it honors Scan#setBatch(through defaultScannerContext in RegionScannerImpl).
> {code}
> // 1.1.3
> public class ClientSideRegionScanner extends AbstractClientScanner {
>   ...
>   @Override
>   public Result next() throws IOException {
>     values.clear();
>     scanner.nextRaw(values);
>     ...
> {code}
>  
> \\
> But in 1.0.3 and 0.98.17, ClientSideRegionScanner calls RegionScannerImpl#next() with
limit=-1, so it ignores Scan#setBatch.
> {code}
> // 1.0.3 and 0.98.17
> public class ClientSideRegionScanner extends AbstractClientScanner {
>   ...
>   @Override
>   public Result next() throws IOException {
>     values.clear();
>     scanner.nextRaw(values, -1); // pass -1 as limit so that we see the whole row.
>     ...
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message