hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15270) Use appropriate encoding for "filter" field in TaskMonitorTmpl.jamon
Date Wed, 17 Feb 2016 01:18:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15149644#comment-15149644
] 

stack commented on HBASE-15270:
-------------------------------

TestHRegion failure is not your fault.

I was going to ask if we should do any escaping w/ the new fancy stuff added by a certain
[~asamir] over in HBASE-15122? ... but looking at the patch I see you do this already. +1
on patch.

> Use appropriate encoding for "filter" field in TaskMonitorTmpl.jamon 
> ---------------------------------------------------------------------
>
>                 Key: HBASE-15270
>                 URL: https://issues.apache.org/jira/browse/HBASE-15270
>             Project: HBase
>          Issue Type: Sub-task
>          Components: UI
>    Affects Versions: 2.0.0, 1.2.1, 1.1.3
>            Reporter: Samir Ahmic
>            Assignee: Samir Ahmic
>             Fix For: 2.0.0, 1.2.1, 1.1.3
>
>         Attachments: HBASE-15270_v0.patch, HBASE-15270_v1.patch
>
>
> In TaskMonitorTmpl.jamon  we have this line
> {code}
> <li><a href="?format=json&filter=<% filter %>">View as JSON</a></li>
> {code}
> which is allowing "filter" parameter to take arbitrary value. I suggest that we encode
this value for HTML.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message