hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15264) Implement a fan out HDFS OutputStream
Date Fri, 19 Feb 2016 17:31:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15154528#comment-15154528
] 

stack commented on HBASE-15264:
-------------------------------

Lets do in a branch first? Then you can commit willy-nilly and we can bring it all into branch
in one lump as working WAL provider alternative? Make a branch named for the umbrella JIRA
and go for it.

Here is some review on the patch:

Why are your classes all in util and not in io or under regionserver.wal? These would be better
locations? Though, looking through the imports, it is almost as though this set of classes
could go into hbase-common rather than into hbase-server. That'd be cool. Might be good to
do that so you can be sure you are not dragging in hbase dependency. Will make it easier then
upstreaming your work to hdfs. Just a thought (On further review, I see dependency on FSUtil...
moving to hbase-common is not important... can do later).

Give your class javadoc a reread/edit. You'll find stuff to fix.

That is good that you list differences vs default dfsos.

... will be back...








> Implement a fan out HDFS OutputStream
> -------------------------------------
>
>                 Key: HBASE-15264
>                 URL: https://issues.apache.org/jira/browse/HBASE-15264
>             Project: HBase
>          Issue Type: Sub-task
>          Components: util, wal
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15264-v1.patch, HBASE-15264-v2.patch, HBASE-15264-v3.patch,
HBASE-15264-v4.patch, HBASE-15264.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message