hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15261) Make Throwable t in DaughterOpener volatile
Date Sat, 13 Feb 2016 15:16:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15146015#comment-15146015

Ted Yu commented on HBASE-15261:

This Throwable is accessed like this:
        if (aOpener.getException() == null) {
I don't see synchronization primitive around the access. Meaning, would the change to volatile
be effective ?

> Make Throwable t in DaughterOpener volatile
> -------------------------------------------
>                 Key: HBASE-15261
>                 URL: https://issues.apache.org/jira/browse/HBASE-15261
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver
>            Reporter: huaxiang sun
>            Assignee: huaxiang sun
>            Priority: Minor
>         Attachments: HBASE-15261-001.patch
> In the region split process, daughter regions are opened in different threads, Throwable
t is set in these threads and it is checked in the calling thread. Need to make it volatile
so the checking will not miss any exceptions from opening daughter regions.

This message was sent by Atlassian JIRA

View raw message