hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15243) Utilize the lowest seek value when all Filters in MUST_PASS_ONE FilterList return SEEK_NEXT_USING_HINT
Date Wed, 24 Feb 2016 17:23:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15163350#comment-15163350
] 

stack commented on HBASE-15243:
-------------------------------

bq. As you can see in the setup, block size is adjusted so that the specified number of rows
would result in multiple blocks (8 for this test).

With no commentary as to why this is necessary or how it pertains to the filter under test....
What is being tested is opaque.

The comment added to the code states in english what the code is doing:

// the seenNonHintReturnCode flag is intended only for Operator.MUST_PASS_ONE branch

No why seenNonHintReturnCode is needed or why its needed for MUST_PASS_ONE or what happens
if this flag is not in place.... Please do better. This stuff is difficult to understand.
Special casing like seenNonHintReturnCode needs to be explained well else every dev who trips
over this code has to work that much harder to figure what is going on.

> Utilize the lowest seek value when all Filters in MUST_PASS_ONE FilterList return SEEK_NEXT_USING_HINT
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15243
>                 URL: https://issues.apache.org/jira/browse/HBASE-15243
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-15243-v1.txt, HBASE-15243-v2.txt, HBASE-15243-v3.txt, HBASE-15243-v4.txt,
HBASE-15243-v5.txt, HBASE-15243-v6.txt
>
>
> As Preston Koprivica pointed out at the tail of HBASE-4394, when all filters in a MUST_PASS_ONE
FilterList return a SEEK_USING_NEXT_HINT code, we should return SEEK_NEXT_USING_HINT from
the FilterList to utilize the lowest seek value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message