hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ted Yu (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15243) Utilize the lowest seek value when all Filters in MUST_PASS_ONE FilterList return SEEK_NEXT_USING_HINT
Date Wed, 24 Feb 2016 05:09:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15160183#comment-15160183
] 

Ted Yu commented on HBASE-15243:
--------------------------------

bq. No commentary on what the likes of this is about?

Added comment in patch v6. Basically not all cases for Operator.MUST_PASS_ALL would return
before exiting the for loop. So a guard is needed.

bq. Can't piggy-back on an already running cluster?

As you can see in the setup, block size is adjusted so that the specified number of rows would
result in multiple blocks (8 for this test).
I don't think the other Filter tests need this setup.

bq. How long does the test run take?

This was from QA run for patch v4:
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 79.131 sec - in org.apache.hadoop.hbase.filter.TestFilterListOrOperatorWithBlkCnt

This was from QA run for patch v5:
Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 15.82 sec - in org.apache.hadoop.hbase.filter.TestFilterListOrOperatorWithBlkCnt

> Utilize the lowest seek value when all Filters in MUST_PASS_ONE FilterList return SEEK_NEXT_USING_HINT
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15243
>                 URL: https://issues.apache.org/jira/browse/HBASE-15243
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: HBASE-15243-v1.txt, HBASE-15243-v2.txt, HBASE-15243-v3.txt, HBASE-15243-v4.txt,
HBASE-15243-v5.txt
>
>
> As Preston Koprivica pointed out at the tail of HBASE-4394, when all filters in a MUST_PASS_ONE
FilterList return a SEEK_USING_NEXT_HINT code, we should return SEEK_NEXT_USING_HINT from
the FilterList to utilize the lowest seek value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message