hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Elser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15221) HTableMultiplexer improvements (stale region locations and resource leaks)
Date Mon, 08 Feb 2016 16:27:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15137172#comment-15137172

Josh Elser commented on HBASE-15221:

I'm tentatively dropping the 98.x fixVersion.

It looks like this was already (attempted to be?) fixed in HBASE-12198. There's a clearCaches
call in HTableMultiplexer in 0.98 that isn't present in the newer branches.

Sadly, there *is* a call in AsyncProcess which looks like it should be triggering a location
cache clear. I need to step back again and look at this some more...

> HTableMultiplexer improvements (stale region locations and resource leaks)
> --------------------------------------------------------------------------
>                 Key: HBASE-15221
>                 URL: https://issues.apache.org/jira/browse/HBASE-15221
>             Project: HBase
>          Issue Type: Bug
>          Components: Client
>            Reporter: Josh Elser
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 2.0.0, 1.2.0, 1.3.0, 1.1.4
>         Attachments: HBASE-15221.001.patch, HBASE-15221.002.patch, HBASE-15221.003.patch,
HBASE-15221.branch-1.patch, HBASE-15221.v4.patch
> It looks like HTableMultiplexer has a couple of issues.
> Upon failing to send a Put to the appropriate RS, the Put is re-queued back into the
system. Normally this is fine as such an exception is transient and the Put would eventually
succeed. However, in the case where the Put was rejected because of a NotServingRegionException
(e.g. split, balance, merge), the re-queuing of the Put will end up using the same cached
HRegionLocation. This means that the Put will just be repeatedly sent back to the same RS
over and over again, eventually being dropped on the floor. Need to invalidate the location
cache (or make sure we refresh it) when we re-queue the Put.
> The internal ClusterConnection is also leaked. If a user creates many HTableMultiplexers,
they'll eventually run into issues (memory, zk connections, etc) because they'll never get
cleaned up. HTableMultiplexer needs a close method.

This message was sent by Atlassian JIRA

View raw message