hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15214) Valid mutate Ops fail with RPC Codec in use and region moves across
Date Thu, 04 Feb 2016 21:39:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15133085#comment-15133085
] 

Hadoop QA commented on HBASE-15214:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 0s {color} | {color:blue}
Docker mode activated. {color} |
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} |
{color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color}
| {color:green} The patch appears to include 1 new or modified test files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 1s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 3s {color} | {color:green}
master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 4s {color} | {color:green}
master passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 6m 25s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 28s {color}
| {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 1s {color} | {color:red}
hbase-client in master has 4 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s {color} |
{color:green} master passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 53s {color} |
{color:green} master passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 6s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 58s {color} |
{color:green} the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 58s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 52s {color} |
{color:green} the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 52s {color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 4m 12s {color} | {color:red}
Patch generated 2 new checkstyle issues in hbase-server (total was 138, now 140). {color}
|
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 27s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color}
| {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 23m 52s {color}
| {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2
2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 57s {color} |
{color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 9s {color} | {color:green}
the patch passed with JDK v1.8.0_72 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 6s {color} | {color:green}
the patch passed with JDK v1.7.0_95 {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 8s {color} | {color:green}
hbase-client in the patch passed with JDK v1.8.0_72. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 86m 49s {color} | {color:red}
hbase-server in the patch failed with JDK v1.8.0_72. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 29s {color} | {color:green}
hbase-client in the patch passed with JDK v1.7.0_95. {color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 103m 30s {color} | {color:red}
hbase-server in the patch failed with JDK v1.7.0_95. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 30s {color}
| {color:green} Patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 250m 32s {color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| JDK v1.8.0_72 Timed out junit tests | org.apache.hadoop.hbase.util.TestHBaseFsckOneRS |
|   | org.apache.hadoop.hbase.util.TestHBaseFsckTwoRS |
| JDK v1.7.0_95 Failed junit tests | hadoop.hbase.regionserver.TestRegionServerHostname |
| JDK v1.7.0_95 Timed out junit tests | org.apache.hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
|
|   | org.apache.hadoop.hbase.coprocessor.TestClassLoading |
|   | org.apache.hadoop.hbase.coprocessor.TestRegionObserverBypass |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=1.9.1 Server=1.9.1 Image:yetus/hbase:date2016-02-04 |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12786298/HBASE-15214_V2.patch
|
| JIRA Issue | HBASE-15214 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  hbaseanti  checkstyle
 compile  |
| uname | Linux 6c3e0c1bd786 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12
UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / f5fba2b |
| findbugs | v3.0.0 |
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/430/artifact/patchprocess/branch-findbugs-hbase-client-warnings.html
|
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/430/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/430/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt
|
| unit | https://builds.apache.org/job/PreCommit-HBASE-Build/430/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
|
| unit test logs |  https://builds.apache.org/job/PreCommit-HBASE-Build/430/artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0_72.txt
https://builds.apache.org/job/PreCommit-HBASE-Build/430/artifact/patchprocess/patch-unit-hbase-server-jdk1.7.0_95.txt
|
| JDK v1.7.0_95  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/430/testReport/
|
| modules | C: hbase-client hbase-server U: . |
| Max memory used | 446MB |
| Powered by | Apache Yetus 0.1.0   http://yetus.apache.org |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/430/console |


This message was automatically generated.



> Valid mutate Ops fail with RPC Codec in use and region moves across
> -------------------------------------------------------------------
>
>                 Key: HBASE-15214
>                 URL: https://issues.apache.org/jira/browse/HBASE-15214
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 0.98.0
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>            Priority: Critical
>             Fix For: 2.0.0, 1.3.0, 1.2.1, 1.1.4, 1.0.4, 0.98.18
>
>         Attachments: HBASE-15214.patch, HBASE-15214_V2.patch
>
>
> Test failures in HBASE-15198 lead to this bug. Till now we are not doing cell block (codec
usage) for write requests. (Client -> server)  Once we enabled Codec usage by default,
aw this issue.
> A multi request came to RS with mutation for different regions. One of the region which
was in this RS got unavailable now.  In RsRpcServices#multi, we will fail that entire RegionAction
(with N mutations in it) in that MultiRequest.  Then we will continue with remaining RegionActions.
 Those Regions might be available.  (The failed RegionAction will get retried from client
after fetching latest region location).  This all works fine in pure PB requests world. When
a Codec is used, we wont convert the Mutation Cell to PB Cells and pack them in PB Message.
Instead we will pass all Cells serialized into one byte[] cellblock. Using Decoder we will
iterate over these cells at server side. Each Mutation PB will know only the number of cells
associated with it.  As in above case when an entire RegionAction was skipped, there might
be N Mutations under that which might have corresponding Cells in the cellblock. We are not
doing the skip in that Iterator. This makes the later Mutations (for other Regions) to refer
to invalid Cells and try to put those into the a different region. This will make HRegion#checkRow()
to throw WrongRegionException which will be treated as Sanity check failure and so throwing
back a DNRIOE to client. So the op will get failed for the user code.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message