hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Elliott Clark (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15212) RRCServer should enforce max request size
Date Fri, 05 Feb 2016 00:34:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15133413#comment-15133413
] 

Elliott Clark commented on HBASE-15212:
---------------------------------------

Yeah that's waaaay too aggressive. We shouldn't be guarding against lots of requests being
too large. That's the job of total call queue size. We should only be guarding against things
that are outrageously large.
I would vote 256mb flat or something like that otherwise we are going to break existing people
pretty hard.

> RRCServer should enforce max request size 
> ------------------------------------------
>
>                 Key: HBASE-15212
>                 URL: https://issues.apache.org/jira/browse/HBASE-15212
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 2.0.0, 1.3.0
>
>         Attachments: hbase-15212_v1.patch
>
>
> A TODO from HBASE-15177 was that we are not protecting the RPCServer in case an RPC request
with a very large size is received. This might cause the server to go OOM because we are allocating
the RPC serialization into a BB. Instead we should reject the RPC and close the connection.
 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message