hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15205) Do not find the replication scope for every WAL#append()
Date Thu, 25 Feb 2016 07:10:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15166841#comment-15166841
] 

stack commented on HBASE-15205:
-------------------------------

I'd be +1 on this. Looks much better. We can clean up clearing of scopes in certain contexts
in another patch. Seems to be too many constructors on WALKey but can fix that in another
patch too. Thanks for putting up w/ my review [~ram_krish]

> Do not find the replication scope for every WAL#append()
> --------------------------------------------------------
>
>                 Key: HBASE-15205
>                 URL: https://issues.apache.org/jira/browse/HBASE-15205
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15204_6.patch, HBASE-15205.patch, HBASE-15205_1.patch, HBASE-15205_2.patch,
HBASE-15205_3.patch, HBASE-15205_4.patch, HBASE-15205_6.patch, HBASE-15205_6.patch, HBASE-15205_7.patch,
HBASE-15205_8.patch, HBASE-15205_9.patch, ScopeWALEdits.jpg, ScopeWALEdits_afterpatch.jpg
>
>
> After the byte[] and char[] the other top contributor for lot of GC (though it is only
2.86%) is the UTF_8.newDecoder.
> This happens because for every WAL append we try to calculate the replication scope associate
with the families associated with the TableDescriptor. I think per WAL append doing this is
very costly and creates lot of garbage. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message