hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-15205) Do not find the replication scope for every WAL#append()
Date Thu, 25 Feb 2016 06:26:18 GMT

     [ https://issues.apache.org/jira/browse/HBASE-15205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

ramkrishna.s.vasudevan updated HBASE-15205:
    Attachment: HBASE-15205_8.patch

Latest patch. Removed replicationScope from FSWALEntry. WALKey construction itself will now
have replicationScope. As I said earlier since we are now passing the scope during WALKey
construction itself now it is upto us to nullify the scopes in logKey when ever it is not
needed. I felt that was not looking clean. Still we are removing HTD from WAL#append() and
things work as in previous patches. 
Now we will call this 
+    if ((!replicationForBulkLoadEnabled && !foundOtherEdits) || logEdit.isReplay())
+      logKey.serializeReplicationScope(false);
instead of setReplciationScope(). Inside WALKEy#serializeReplicationScope() we will just nullify
the replicationScope that was passed during construction. 

> Do not find the replication scope for every WAL#append()
> --------------------------------------------------------
>                 Key: HBASE-15205
>                 URL: https://issues.apache.org/jira/browse/HBASE-15205
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>             Fix For: 2.0.0
>         Attachments: HBASE-15204_6.patch, HBASE-15205.patch, HBASE-15205_1.patch, HBASE-15205_2.patch,
HBASE-15205_3.patch, HBASE-15205_4.patch, HBASE-15205_6.patch, HBASE-15205_6.patch, HBASE-15205_7.patch,
HBASE-15205_8.patch, ScopeWALEdits.jpg, ScopeWALEdits_afterpatch.jpg
> After the byte[] and char[] the other top contributor for lot of GC (though it is only
2.86%) is the UTF_8.newDecoder.
> This happens because for every WAL append we try to calculate the replication scope associate
with the families associated with the TableDescriptor. I think per WAL append doing this is
very costly and creates lot of garbage. 

This message was sent by Atlassian JIRA

View raw message