hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15202) Reduce garbage while setting response
Date Tue, 02 Feb 2016 22:27:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129190#comment-15129190
] 

Enis Soztutar commented on HBASE-15202:
---------------------------------------

Good one. Can we move Bytes.toBytes() to be inside IPCUtil instead. Bytes is a public facing
class, and this CIS method is only for internal consumption. Other than that +1. 

> Reduce garbage while setting response
> -------------------------------------
>
>                 Key: HBASE-15202
>                 URL: https://issues.apache.org/jira/browse/HBASE-15202
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15202.patch, HBASE-15202_1.patch
>
>
> Probably this can move under HBASE-15177.  During RpcServer#setResponse we do IPCUtil.getDelimitedMessageAsByteBuffer
for the header and result. This internally creates a byte[], CodedOutputStream and a BB. Then
the totalSize is also wrapped in a BB. 
> Finally all these BB are passed to BufferChain along with the Cellblock.
> This JIRA is to reduce the number of objects that we create here and allow one BB from
this header, result and total Size along with one CodedOutputStream and pass this BB along
with the Cellblocks to the Bufferchain. From the JMC tool can observe around 2% lesser object
allocation arising out of these objects. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message