hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jerry He (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15201) Add hbase-spark to hbase assembly
Date Wed, 03 Feb 2016 05:38:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15129828#comment-15129828
] 

Jerry He commented on HBASE-15201:
----------------------------------

I dig a little more.  
Here is the reason for the QA build problem.
The steps involved in the QA build:

{noformat}
============================================================================
============================================================================
                      Pre-patch master maven install
============================================================================
============================================================================
cd /testptch/hbase
mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-1 -DHBasePatchProcess -fae clean
install -DskipTests=true -Dmaven.javadoc.skip=true > /testptch/patchprocess/branch-mvninstall-root.txt
2>&1
Elapsed:   3m 21s
{noformat}

Note that we do a top level mvn install without the patch.  The hbase-spark pom is updated
in the patch (mark the spark-streaming as 'provided').  But the installed artifact pom is
without the change.
Then in the next step:

{noformat}
============================================================================
============================================================================
                            Patch maven install
============================================================================
============================================================================


cd /testptch/hbase/hbase-assembly
mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-1 -DHBasePatchProcess -fae clean
install -DskipTests=true -Dmaven.javadoc.skip=true > /testptch/patchprocess/patch-mvninstall-hbase-assembly.txt
2>&1
Elapsed:   0m 18s
cd /testptch/hbase/hbase-spark
mvn -Dmaven.repo.local=/home/jenkins/yetus-m2/hbase-master-1 -DHBasePatchProcess -fae clean
install -DskipTests=true -Dmaven.javadoc.skip=true > /testptch/patchprocess/patch-mvninstall-hbase-spark.txt
2>&1
Elapsed:   1m 16s

hbase-assembly in the patch failed.
{noformat}

We went into hbase-assembly directory and did a 'mvn install' in there.  But the other pom
in the local repo was still the old bad one.
Thus it tried to pull in all the dependencies of spark-streaming, which it should not have
done if it had seen the new pom in the local repo.

If it had reversed the order shown in the quoted text (built and installed the hbase-spark
module first), we would be good as well.

These new steps of this new QA run are interesting ...  Looks like it only goes into the modules
touched by the patch to do the mvn install again ...

> Add hbase-spark to hbase assembly
> ---------------------------------
>
>                 Key: HBASE-15201
>                 URL: https://issues.apache.org/jira/browse/HBASE-15201
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Jerry He
>            Assignee: Jerry He
>            Priority: Minor
>         Attachments: HBASE-15201.patch
>
>
> hbase-spark currently is missing from hbase assembly.
> We should add it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message