hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15151) turn off strict findbugs in precommit tests
Date Thu, 11 Feb 2016 19:07:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15143289#comment-15143289
] 

Sean Busbey commented on HBASE-15151:
-------------------------------------

I didn't think all modules on all branches were at 0 yet. If that's true then maybe we can
ignore this again.

My understanding is that in non-strict mode we'll still get a result line that says there
are extant findbugs problems, it'll just be with a vote of 0 and in blue (rather than -1 and
red). I suspect this means the folks who would look out for existing problems will still notice
it and everyone else will become blind to it.

> turn off strict findbugs in precommit tests
> -------------------------------------------
>
>                 Key: HBASE-15151
>                 URL: https://issues.apache.org/jira/browse/HBASE-15151
>             Project: HBase
>          Issue Type: Task
>          Components: build, test
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>            Priority: Critical
>
> the "-1" for extant findbugs warnings has confused interpretation of our precommit checks
enough that we should switch to non-strict mode.
> It will still record the number of findbugs warnings present before the patch, but it'll
vote "0" rather than calling attention to things via a -1.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message