hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sean Busbey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15122) Servlets generate XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER findbugs warnings
Date Mon, 01 Feb 2016 20:26:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15126962#comment-15126962
] 

Sean Busbey commented on HBASE-15122:
-------------------------------------

I think it was just specific to the prior case. In that case it was a simple filter for adding
an HTTP header to avoid framing our UI. This seems sufficiently more advanced to be worth
it.

Is there a more up to date version of the ESAPI that avoids the inclusion of Xerces? Presuming
I can find the other place it's bleeding in, I'd really like to avoid it.

> Servlets generate XSS_REQUEST_PARAMETER_TO_SERVLET_WRITER findbugs warnings
> ---------------------------------------------------------------------------
>
>                 Key: HBASE-15122
>                 URL: https://issues.apache.org/jira/browse/HBASE-15122
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Priority: Critical
>         Attachments: HBASE-15122-v0-master, HBASE-15122.patch
>
>
> In our JMXJsonServlet we are doing this:
>         jsonpcb = request.getParameter(CALLBACK_PARAM);
>         if (jsonpcb != null) {
>           response.setContentType("application/javascript; charset=utf8");
>           writer.write(jsonpcb + "(");
> ... 
> Findbugs complains rightly. There are other instances in our servlets and then there
are the pages generated by jamon excluded from findbugs checking (and findbugs volunteers
that it is dumb in this regard finding only the most egregious of violations).
> We have no sanitizing tooling in hbase that I know of (correct me if I am wrong). I started
to pull on this thread and it runs deep. Our Jamon templating (last updated in 2013 and before
that, in 2011) engine doesn't seem to have sanitizing means either and there seems to be outstanding
XSS complaint against jamon that goes unaddressed.
> Could pull in something like https://www.owasp.org/index.php/OWASP_Java_Encoder_Project
and run all emissions via it or get a templating engine that has sanitizing built in. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message