hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Vimont (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-14877) maven archetype: client application
Date Fri, 19 Feb 2016 00:51:18 GMT

    [ https://issues.apache.org/jira/browse/HBASE-14877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15153455#comment-15153455
] 

Daniel Vimont commented on HBASE-14877:
---------------------------------------

Both your points relate to converting the exemplar (which SHOULD have all proper dependencies/inheritances
within the hbase project hierarchy) into a standalone project (which needs to have all hbase
project dependencies removed/replaced before it is used to produce an archetype). The conversion
of the exemplar is elaborated upon a bit in [footnote 5 of the README|https://github.com/dvimont/test_hbasearchetypes_readme#f5].

To address your points:
{quote}
change the java 1.7 compile source/target in the pom? should this be inherited from hbase
$compileSource?
{quote}
{color:red}YES{color}, thanks for pointing this out! You are absolutely right that the value
"1.7" should NOT be hardcoded into hbase-client-project/pom.xml in the {{maven.compiler.source}}
and {{maven.compiler.target}} elements, but should be inherited via {{$compileSource}}. Then,
just as {{$project.version}} is converted into a literal value by the maven-resources-plugin
(see footnote 5 again), so too will {{$compileSource}} be converted into a literal value.
{quote}
ah after running 'mvn archetype:generate -Dfilter=hbase' i see {{$project.version}} gets replaced
with the hbase project version. So we'll just inherit whatever version hbase has.
{quote}
{color:red}EXACTLY!{color} The variable {{$project.version}} gets replaced by an appropriate
literal value by the maven-resources-plugin.
----

{color:green}*I will make {{$compileSource}} related changes according to your first bullet
point above (also modifying the text of footnote 5 accordingly) and submit a revised patch.*{color}

BTW, HBASE-15176 has already been added for "end-user-oriented documentation". As soon as
the first v1.3 archetype becomes publicly available via the Maven central repository, I'll
add an appropriate entry to the end-user Reference Guide text.

*THANKS!*

> maven archetype: client application
> -----------------------------------
>
>                 Key: HBASE-14877
>                 URL: https://issues.apache.org/jira/browse/HBASE-14877
>             Project: HBase
>          Issue Type: Sub-task
>          Components: build, Usability
>    Affects Versions: 2.0.0
>            Reporter: Nick Dimiduk
>            Assignee: Daniel Vimont
>              Labels: archetype, beginner, maven
>         Attachments: HBASE-14877-v2.patch, HBASE-14877-v3.patch, HBASE-14877-v4.patch,
HBASE-14877-v5.patch, HBASE-14877.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message