Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 74F461874C for ; Fri, 22 Jan 2016 14:57:40 +0000 (UTC) Received: (qmail 798 invoked by uid 500); 22 Jan 2016 14:57:40 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 700 invoked by uid 500); 22 Jan 2016 14:57:40 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 640 invoked by uid 99); 22 Jan 2016 14:57:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 22 Jan 2016 14:57:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D98A82C1F5D for ; Fri, 22 Jan 2016 14:57:39 +0000 (UTC) Date: Fri, 22 Jan 2016 14:57:39 +0000 (UTC) From: "Yu Li (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15148) Resolve IS2_INCONSISTENT_SYNC findbugs warning in AuthenticationTokenSecretManager MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112495#comment-15112495 ] Yu Li commented on HBASE-15148: ------------------------------- Thanks [~tedyu] for review and help commit. Thanks [~busbey] for review. > Resolve IS2_INCONSISTENT_SYNC findbugs warning in AuthenticationTokenSecretManager > ---------------------------------------------------------------------------------- > > Key: HBASE-15148 > URL: https://issues.apache.org/jira/browse/HBASE-15148 > Project: HBase > Issue Type: Bug > Reporter: Yu Li > Assignee: Yu Li > Fix For: 2.0.0, 1.2.0, 1.3.0 > > Attachments: HBASE-15148.patch, HBASE-15148.patch > > > After efforts in HBASE-15118, we still see IS2_INCONSISTENT_SYNC warning in AuthenticationTokenSecretManager in [HadoopQA report | https://builds.apache.org/job/PreCommit-HBASE-Build/197/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html] for HBASE-13960: > {noformat} > In class org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager > Field org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.lastKeyUpdate > Synchronized 50% of the time > Unsynchronized access at AuthenticationTokenSecretManager.java:[line 343] > Synchronized access at AuthenticationTokenSecretManager.java:[line 278] > {noformat} > Checking the code, we could see {{synchronized (this)}} in line 343 is synchronizing on the instance of the subclass {{AuthenticationTokenSecretManager$LeaderElector}} while {{lastKeyUpdate}} is a variable of the parent class instance > Will fix the issue in this JIRA -- This message was sent by Atlassian JIRA (v6.3.4#6332)