Return-Path: 
 <issues-return-229259-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 4D5D3176A1
	for <apmail-hbase-issues-archive@www.apache.org>;
 Tue, 26 Jan 2016 13:16:40 +0000 (UTC)
Received: (qmail 34273 invoked by uid 500); 26 Jan 2016 13:16:40 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 34224 invoked by uid 500); 26 Jan 2016 13:16:40 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 34207 invoked by uid 99); 26 Jan 2016 13:16:40 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jan 2016 13:16:40 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id D01722C1F5D
	for <issues@hbase.apache.org>; Tue, 26 Jan 2016 13:16:39 +0000 (UTC)
Date: Tue, 26 Jan 2016 13:16:39 +0000 (UTC)
From: "Yu Li (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12932397.1453205630000.211357.1453814199849@Atlassian.JIRA>
In-Reply-To: <JIRA.12932397.1453205630000@Atlassian.JIRA>
References: <JIRA.12932397.1453205630000@Atlassian.JIRA>
 <JIRA.12932397.1453205630119@arcas>
Subject: [jira] [Commented] (HBASE-15129) Set default value for
 hbase.fs.tmp.dir rather than fully depend on hbase-default.xml
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-15129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117168#comment-15117168 ] 

Yu Li commented on HBASE-15129:
-------------------------------

Checked and confirmed the findbugs issues were not caused by the change here. 

Tried the maven install command {{-DHBasePatchProcess -fae clean install -DskipTests=true -Dmaven.javadoc.skip=true}} in local and it passed w/o problem, not sure why it failed in the HadoopQA run, probably an env issue.

> Set default value for hbase.fs.tmp.dir rather than fully depend on hbase-default.xml
> ------------------------------------------------------------------------------------
>
>                 Key: HBASE-15129
>                 URL: https://issues.apache.org/jira/browse/HBASE-15129
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Yu Li
>            Assignee: Yu Li
>         Attachments: HBASE-15129.patch, HBASE-15129_v2.patch
>
>
> One of our users has observed below error when our cluster upgrades from 0.98.12 to 1.1.2:
> {noformat}
> java.lang.IllegalArgumentException: Can not create a Path from a null string
>         at org.apache.hadoop.fs.Path.checkPathArg(Path.java:122)
>         at org.apache.hadoop.fs.Path.<init>(Path.java:134)
>         at org.apache.hadoop.fs.Path.<init>(Path.java:88)
>         at org.apache.hadoop.hbase.mapreduce.HFileOutputFormat2.configurePartitioner(HFileOutputFormat2.java:639)
>         at org.apache.hadoop.hbase.mapreduce.HFileOutputFormat2.configureIncrementalLoad(HFileOutputFormat2.java:489)
> {noformat}
> And checking the application code:
> {code}
>   private Job createJob(Configuration jobConf) throws IOException {
>     String tableName = jobConf.get(TABLE_NAME_KEY);
>     Job job = new Job(jobConf);
>     Configuration tableConf = HBaseConfiguration.create();
>     HTable table = new HTable(tableConf, tableName);
>     HFileOutputFormat2.configureIncrementalLoad(job, table);
>     return job;
>   }
> {code}
> We could see the user has his own hbase-independent job configuration, so our current code in HFileOutputFormat2:
> {code}
> Path partitionsPath = new Path(conf.get("hbase.fs.tmp.dir"), "partitions_" + UUID.randomUUID());
> {code}
> will return a null string and cause the above exception.
> We propose to add default value in the code rather than depend on hbase-default.xml in this JIRA.
> This is an improvement for HBASE-13625



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)