Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 265BC1867F for ; Tue, 19 Jan 2016 01:38:45 +0000 (UTC) Received: (qmail 13153 invoked by uid 500); 19 Jan 2016 01:38:40 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 13075 invoked by uid 500); 19 Jan 2016 01:38:40 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 13050 invoked by uid 99); 19 Jan 2016 01:38:39 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Jan 2016 01:38:39 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id CA6C22C1F57 for ; Tue, 19 Jan 2016 01:38:39 +0000 (UTC) Date: Tue, 19 Jan 2016 01:38:39 +0000 (UTC) From: "chenrongwei (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15126) HBaseFsck's checkRegionBoundaries function set the 'storesFirstKey' was incorrect. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106092#comment-15106092 ] chenrongwei commented on HBASE-15126: ------------------------------------- OK,At first I added a unit test case,however according to the building tips like "Patch causes 11 errors with Hadoop v2.4.0." which I don't understand,so i removed the unit test case. > HBaseFsck's checkRegionBoundaries function set the 'storesFirstKey' was incorrect. > ----------------------------------------------------------------------------------- > > Key: HBASE-15126 > URL: https://issues.apache.org/jira/browse/HBASE-15126 > Project: HBase > Issue Type: Bug > Components: hbck > Affects Versions: 2.0.0 > Reporter: chenrongwei > Assignee: chenrongwei > Attachments: HBASE-15126-v001.patch, HBASE-15126-v002.patch > > > HBaseFsck's checkRegionBoundaries function set the 'currentRegionBoundariesInformation.storesFirstKey' was incorrect.I think it should be set like below, > currentRegionBoundariesInformation.storesFirstKey = keyOnly(storeFirstKey); > but current the 'currentRegionBoundariesInformation.storesFirstKey ' is just set to 'storeFirstKey',which will cause to comparator.compare(currentRegionBoundariesInformation.storesFirstKey, > currentRegionBoundariesInformation.metaFirstKey) get a wrong result. Because it just compared the rowkey's length. -- This message was sent by Atlassian JIRA (v6.3.4#6332)