Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E860F18721 for ; Mon, 18 Jan 2016 12:43:40 +0000 (UTC) Received: (qmail 88790 invoked by uid 500); 18 Jan 2016 12:43:40 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 88739 invoked by uid 500); 18 Jan 2016 12:43:40 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 88537 invoked by uid 99); 18 Jan 2016 12:43:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Jan 2016 12:43:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E264F2C1F58 for ; Mon, 18 Jan 2016 12:43:39 +0000 (UTC) Date: Mon, 18 Jan 2016 12:43:39 +0000 (UTC) From: "Hadoop QA (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-15097) When the scan operation covered two regions,sometimes the final results have duplicated rows. MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15097?page=3Dcom.atlassia= n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D151= 05234#comment-15105234 ]=20 Hadoop QA commented on HBASE-15097: ----------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} = 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color= } | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m= 0s {color} | {color:green} The patch does not contain any @author tags. {c= olor} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s= {color} | {color:red} The patch doesn't appear to include any new or modif= ied tests. Please justify why no new tests are needed for this patch. Also = please list what manual steps were performed to verify this patch. {color} = | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 2m 43s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m= 42s {color} | {color:green} master passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m= 40s {color} | {color:green} master passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 5m 3s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}= 0m 18s {color} | {color:green} master passed {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 9s {= color} | {color:red} hbase-server in master has 82 extant Findbugs warnings= . {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m= 34s {color} | {color:green} master passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m= 33s {color} | {color:green} master passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}= 0m 47s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m= 48s {color} | {color:green} the patch passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 4= 8s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m= 36s {color} | {color:green} the patch passed with JDK v1.7.0_79 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 3= 6s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}= 4m 43s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green}= 0m 15s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green}= 0m 0s {color} | {color:green} Patch has no whitespace issues. {color} | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 1m 3= 4s {color} | {color:red} Patch causes 11 errors with Hadoop v2.4.0. {color}= | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 3m 3= s {color} | {color:red} Patch causes 11 errors with Hadoop v2.4.1. {color} = | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 4m 3= 8s {color} | {color:red} Patch causes 11 errors with Hadoop v2.5.0. {color}= | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 6m 1= 2s {color} | {color:red} Patch causes 11 errors with Hadoop v2.5.1. {color}= | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 7m 4= 2s {color} | {color:red} Patch causes 11 errors with Hadoop v2.5.2. {color}= | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 9m 1= 5s {color} | {color:red} Patch causes 11 errors with Hadoop v2.6.1. {color}= | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 10m = 50s {color} | {color:red} Patch causes 11 errors with Hadoop v2.6.2. {color= } | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 12m = 36s {color} | {color:red} Patch causes 11 errors with Hadoop v2.6.3. {color= } | | {color:red}-1{color} | {color:red} hadoopcheck {color} | {color:red} 14m = 20s {color} | {color:red} Patch causes 11 errors with Hadoop v2.7.1. {color= } | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2= m 20s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m= 30s {color} | {color:green} the patch passed with JDK v1.8.0 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m= 34s {color} | {color:green} the patch passed with JDK v1.7.0_79 {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 84m 1s {col= or} | {color:red} hbase-server in the patch failed with JDK v1.8.0. {color}= | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 82m 15s {co= lor} | {color:red} hbase-server in the patch failed with JDK v1.7.0_79. {co= lor} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green}= 0m 14s {color} | {color:green} Patch does not generate ASF License warning= s. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 204m 25s {co= lor} | {color:black} {color} | \\ \\ || Reason || Tests || | JDK v1.8.0 Failed junit tests | hadoop.hbase.util.TestHBaseFsckOneRS | | JDK v1.7.0_79 Failed junit tests | hadoop.hbase.util.TestHBaseFsckOneRS | \\ \\ || Subsystem || Report/Notes || | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/1278283= 4/HBASE-15097-v002.patch | | JIRA Issue | HBASE-15097 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck= hbaseanti checkstyle compile | | uname | Linux asf902.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SM= P PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build= /component/dev-support/hbase-personality.sh | | git revision | master / 47fc696 | | findbugs | v3.0.0 | | findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/176/artifa= ct/patchprocess/branch-findbugs-hbase-server-warnings.html | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/176/artifact/p= atchprocess/patch-unit-hbase-server-jdk1.8.0.txt | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/176/artifact/p= atchprocess/patch-unit-hbase-server-jdk1.7.0_79.txt | | unit test logs | https://builds.apache.org/job/PreCommit-HBASE-Build/176= /artifact/patchprocess/patch-unit-hbase-server-jdk1.8.0.txt https://builds.= apache.org/job/PreCommit-HBASE-Build/176/artifact/patchprocess/patch-unit-h= base-server-jdk1.7.0_79.txt | | JDK v1.7.0_79 Test Results | https://builds.apache.org/job/PreCommit-HBA= SE-Build/176/testReport/ | | modules | C: hbase-server U: hbase-server | | Max memory used | 191MB | | Powered by | Apache Yetus 0.1.0 http://yetus.apache.org | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/176/= console | This message was automatically generated. > When the scan operation covered two regions,sometimes the final results h= ave duplicated rows. > -------------------------------------------------------------------------= -------------------- > > Key: HBASE-15097 > URL: https://issues.apache.org/jira/browse/HBASE-15097 > Project: HBase > Issue Type: Bug > Components: regionserver > Affects Versions: 1.1.2 > Environment: centos 6.5 > hbase 1.1.2=20 > Reporter: chenrongwei > Assignee: chenrongwei > Attachments: HBASE-15097-v001.patch, HBASE-15097-v002.patch, outp= ut.log, rowkey.txt, snapshot2016-01-13 pm 8.42.37.png > > Original Estimate: 24h > Remaining Estimate: 24h > > When the scan operation=E2=80=98s start key and end key covered two regio= ns,the first region returned the rows which were beyond of its' end key.So,= this finally leads to duplicated rows in the results. > To avoid this problem,we should add a judgment before setting the variabl= e "stopRow" in the class of HRegion,like follow: > if (Bytes.equals(scan.getStopRow(), HConstants.EMPTY_END_ROW)= && !scan.isGetScan()) { > this.stopRow =3D null; > } else { > if (Bytes.compareTo(scan.getStopRow(), this.getRegionInfo= ().getEndKey()) >=3D 0) { > this.stopRow =3D this.getRegionInfo().getEndKey(); > } else { > this.stopRow =3D scan.getStopRow(); > } > } -- This message was sent by Atlassian JIRA (v6.3.4#6332)