Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 355131828C for ; Tue, 5 Jan 2016 08:36:45 +0000 (UTC) Received: (qmail 10120 invoked by uid 500); 5 Jan 2016 08:36:40 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 10070 invoked by uid 500); 5 Jan 2016 08:36:40 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 10036 invoked by uid 99); 5 Jan 2016 08:36:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2016 08:36:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D61352C1F5A for ; Tue, 5 Jan 2016 08:36:39 +0000 (UTC) Date: Tue, 5 Jan 2016 08:36:39 +0000 (UTC) From: "Jonathan Hsieh (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-15069) Unify HFile Writer and Reader creation patterns MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonathan Hsieh updated HBASE-15069: ----------------------------------- Attachment: hbase-15069.v2.patch v2 fixes bug that cause some of the bulkload related tests to fail. > Unify HFile Writer and Reader creation patterns > ----------------------------------------------- > > Key: HBASE-15069 > URL: https://issues.apache.org/jira/browse/HBASE-15069 > Project: HBase > Issue Type: Bug > Components: HFile > Affects Versions: 2.0.0 > Reporter: Jonathan Hsieh > Assignee: Jonathan Hsieh > Fix For: 2.0.0 > > Attachments: hbase-15069.patch, hbase-15069.v2.patch > > > There are a plethora of different static methods sprinkled through out HStoreFile and HFile, and many tests that have extraneous calls to 'new CacheConfig(conf)' or essentially extraneous FileSystem arguments threaded through out the code. > This patch forces all creation to go through HFile Reader and Writer Builders, eliminates all static Builder constructors, and limits the exposure Reader/Writers . It also forces all HFile writer uses outside of the o.a.h.h.io.hfile package to use the StoreFile writers -- This message was sent by Atlassian JIRA (v6.3.4#6332)