Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7264018C31 for ; Tue, 5 Jan 2016 06:08:40 +0000 (UTC) Received: (qmail 47390 invoked by uid 500); 5 Jan 2016 06:08:40 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 47333 invoked by uid 500); 5 Jan 2016 06:08:40 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 47294 invoked by uid 99); 5 Jan 2016 06:08:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2016 06:08:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id E5BE92C1F5C for ; Tue, 5 Jan 2016 06:08:39 +0000 (UTC) Date: Tue, 5 Jan 2016 06:08:39 +0000 (UTC) From: "Anoop Sam John (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HBASE-15064) Possbile Bug in MultiByteBuffer MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-15064?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anoop Sam John updated HBASE-15064: ----------------------------------- Attachment: HBASE-15064.patch > Possbile Bug in MultiByteBuffer > ------------------------------- > > Key: HBASE-15064 > URL: https://issues.apache.org/jira/browse/HBASE-15064 > Project: HBase > Issue Type: Bug > Components: io > Affects Versions: 2.0.0 > Reporter: deepankar > Assignee: Anoop Sam John > Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-15064.patch > > > While running the newer patches on our production system, I saw this error come couple of times > {noformat} > ipc.RpcServer: Unexpected throwable object > 2016-01-01 16:42:56,090 ERROR [B.defaultRpcServer.handler=20,queue=20,port=60020] ipc.RpcServer: Unexpected throwable object > java.nio.BufferUnderflowException > at java.nio.Buffer.nextGetIndex(Buffer.java:500) > at java.nio.DirectByteBuffer.get(DirectByteBuffer.java:249) > at org.apache.hadoop.hbase.nio.MultiByteBuff.get(MultiByteBuff.java:494) > at org.apache.hadoop.hbase.io.encoding.FastDiffDeltaEncoder$1.decode(FastDiffDeltaEncoder.java:402) > at org.apache.hadoop.hbase.io.encoding.FastDiffDeltaEncoder$1.decodeNext(FastDiffDeltaEncoder.java:517) > at org.apache.hadoop.hbase.io.encoding.BufferedDataBlockEncoder$BufferedEncodedSeeker.next(BufferedDataBlockEncoder.java:815) > at org.apache.hadoop.hbase.regionserver.StoreFileScanner.next(StoreFileScanner.java:138) > {noformat} > Looking at the get code > {code} > if (this.curItem.remaining() == 0) { > if (items.length - 1 == this.curItemIndex) { > // means cur item is the last one and we wont be able to read a long. Throw exception > throw new BufferUnderflowException(); > } > this.curItemIndex++; > this.curItem = this.items[this.curItemIndex]; > } > return this.curItem.get(); > {code} > Can the new currentItem have zero elements (position == limit), does it make sense to change the {{if}} to {{while}} ? {{while (this.curItem.remaining() == 0)}}. This logic is repeated may make sense abstract to a new function if we plan to change to {{if}} to {{while}} -- This message was sent by Atlassian JIRA (v6.3.4#6332)