Return-Path: 
 <issues-return-227379-apmail-hbase-issues-archive=hbase.apache.org@hbase.apache.org>
X-Original-To: apmail-hbase-issues-archive@www.apache.org
Delivered-To: apmail-hbase-issues-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id C540F18121
	for <apmail-hbase-issues-archive@www.apache.org>;
 Mon, 11 Jan 2016 19:25:40 +0000 (UTC)
Received: (qmail 34946 invoked by uid 500); 11 Jan 2016 19:25:40 -0000
Delivered-To: apmail-hbase-issues-archive@hbase.apache.org
Received: (qmail 34895 invoked by uid 500); 11 Jan 2016 19:25:40 -0000
Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hbase.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hbase.apache.org>
List-Post: <mailto:issues@hbase.apache.org>
List-Id: <issues.hbase.apache.org>
Delivered-To: mailing list issues@hbase.apache.org
Received: (qmail 34613 invoked by uid 99); 11 Jan 2016 19:25:40 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 11 Jan 2016 19:25:40 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 062BA2C1F6B
	for <issues@hbase.apache.org>; Mon, 11 Jan 2016 19:25:40 +0000 (UTC)
Date: Mon, 11 Jan 2016 19:25:40 +0000 (UTC)
From: "Hudson (JIRA)" <jira@apache.org>
To: issues@hbase.apache.org
Message-ID: <JIRA.12924765.1451434985000.76155.1452540340022@Atlassian.JIRA>
In-Reply-To: <JIRA.12924765.1451434985000@Atlassian.JIRA>
References: <JIRA.12924765.1451434985000@Atlassian.JIRA>
 <JIRA.12924765.1451434985211@arcas>
Subject: [jira] [Commented] (HBASE-15052) Use EnvironmentEdgeManager in
 ReplicationSource
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


    [ https://issues.apache.org/jira/browse/HBASE-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092527#comment-15092527 ] 

Hudson commented on HBASE-15052:
--------------------------------

SUCCESS: Integrated in HBase-1.3-IT #432 (See [https://builds.apache.org/job/HBase-1.3-IT/432/])
HBASE-15052 Use EnvironmentEdgeManager in ReplicationSource (matteo.bertozzi: rev bb5026c6a42912334bb08cc65e983e80ee49ba06)
* hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSource.java


> Use EnvironmentEdgeManager in ReplicationSource 
> ------------------------------------------------
>
>                 Key: HBASE-15052
>                 URL: https://issues.apache.org/jira/browse/HBASE-15052
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 2.0.0, 1.2.0, 1.1.2, 1.0.3, 0.98.16.1
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>             Fix For: 2.0.0, 1.2.1, 1.1.3, 0.98.17, 1.0.4
>
>         Attachments: HBASE-15052-v0.patch, HBASE-15052-v00.patch
>
>
> ReplicationSource is passing System.currentTimeMillis() to MetricsSource.setAgeOfLastShippedOp() which is subtracting that from EnvironmentEdgeManager.currentTime().
> {code}
> // if there was nothing to ship and it's not an error
> // set "ageOfLastShippedOp" to <now> to indicate that we're current
> metrics.setAgeOfLastShippedOp(System.currentTimeMillis(), walGroupId);
> public void setAgeOfLastShippedOp(long timestamp, String walGroup) {
>     long age = EnvironmentEdgeManager.currentTime() - timestamp;
> {code}
>  we should just use EnvironmentEdgeManager.currentTime() in ReplicationSource



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)