Return-Path: X-Original-To: apmail-hbase-issues-archive@www.apache.org Delivered-To: apmail-hbase-issues-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7035E18254 for ; Tue, 5 Jan 2016 00:51:40 +0000 (UTC) Received: (qmail 63647 invoked by uid 500); 5 Jan 2016 00:51:40 -0000 Delivered-To: apmail-hbase-issues-archive@hbase.apache.org Received: (qmail 63577 invoked by uid 500); 5 Jan 2016 00:51:40 -0000 Mailing-List: contact issues-help@hbase.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Delivered-To: mailing list issues@hbase.apache.org Received: (qmail 63559 invoked by uid 99); 5 Jan 2016 00:51:40 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Jan 2016 00:51:40 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id DAD172C1F5A for ; Tue, 5 Jan 2016 00:51:39 +0000 (UTC) Date: Tue, 5 Jan 2016 00:51:39 +0000 (UTC) From: "Andrew Purtell (JIRA)" To: issues@hbase.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HBASE-14872) Scan different timeRange per column family doesn't percolate down to the memstore MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HBASE-14872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082119#comment-15082119 ] Andrew Purtell commented on HBASE-14872: ---------------------------------------- Comments on the 0.98 patch. The change to Client.proto is wrong. {noformat} 235 optional bool small = 14; 235 optional bool reversed = 15 [default = false] 236 optional uint32 caching = 17; 238 repeated ColumnFamilyTimeRange cf_time_range = 18; 239 } {noformat} On branch-1 and up the cf_time_range tag is 19. This needs to be 19 in 0.98 also for compatibility. I suppose it's too late, the later branch patches have this too, but can we lazily create this tree object (in Query.java)? {noformat} 43 protected Map colFamTimeRangeMap = Maps.newTreeMap(Bytes.BYTES_COMPARATOR); {noformat} The comment and log message here still valid? {noformat} 204 } catch(Exception e) { 205 // This should never happen, unless integer overflow or something extremely wrong... 206 LOG.error("TimeRange failed, likely caused by integer overflow. ", e); 207 throw new IOException(e); 208 } {noformat} Changes to Query, Get, and Scan are ok because they add methods only and all are marked Public+Evolving. > Scan different timeRange per column family doesn't percolate down to the memstore > ---------------------------------------------------------------------------------- > > Key: HBASE-14872 > URL: https://issues.apache.org/jira/browse/HBASE-14872 > Project: HBase > Issue Type: Bug > Components: Client, regionserver, Scanners > Reporter: churro morales > Assignee: churro morales > Fix For: 2.0.0, 1.2.0, 0.98.17 > > Attachments: HBASE-14872-0.98.patch, HBASE-14872-v1.patch, HBASE-14872.patch > > > HBASE-14355 The scan different time range for column family feature was not applied to the memstore it was only done for the store files. This breaks the contract. -- This message was sent by Atlassian JIRA (v6.3.4#6332)