hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15148) Resolve IS2_INCONSISTENT_SYNC findbugs warning in AuthenticationTokenSecretManager
Date Fri, 22 Jan 2016 14:36:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112470#comment-15112470
] 

Hudson commented on HBASE-15148:
--------------------------------

SUCCESS: Integrated in HBase-1.2 #518 (See [https://builds.apache.org/job/HBase-1.2/518/])
HBASE-15148 Resolve IS2_INCONSISTENT_SYNC findbugs warning in (tedyu: rev cd920940b736f1674780a4f8f5fd888023a3551e)
* hbase-server/src/main/java/org/apache/hadoop/hbase/security/token/AuthenticationTokenSecretManager.java


> Resolve IS2_INCONSISTENT_SYNC findbugs warning in AuthenticationTokenSecretManager
> ----------------------------------------------------------------------------------
>
>                 Key: HBASE-15148
>                 URL: https://issues.apache.org/jira/browse/HBASE-15148
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Yu Li
>            Assignee: Yu Li
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: HBASE-15148.patch, HBASE-15148.patch
>
>
> After efforts in HBASE-15118, we still see IS2_INCONSISTENT_SYNC warning in AuthenticationTokenSecretManager
in [HadoopQA report | https://builds.apache.org/job/PreCommit-HBASE-Build/197/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html]
for HBASE-13960:
> {noformat}
> In class org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager
> Field org.apache.hadoop.hbase.security.token.AuthenticationTokenSecretManager.lastKeyUpdate
> Synchronized 50% of the time
> Unsynchronized access at AuthenticationTokenSecretManager.java:[line 343]
> Synchronized access at AuthenticationTokenSecretManager.java:[line 278]
> {noformat}
> Checking the code, we could see {{synchronized (this)}} in line 343 is synchronizing
on the instance of the subclass {{AuthenticationTokenSecretManager$LeaderElector}} while {{lastKeyUpdate}}
is a variable of the parent class instance
> Will fix the issue in this JIRA



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message