hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mikhail Antonov (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15135) Add metrics for storefile age
Date Wed, 27 Jan 2016 01:05:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118391#comment-15118391
] 

Mikhail Antonov commented on HBASE-15135:
-----------------------------------------

Hmm.. So findbug claims that --

org.apache.hadoop.hbase.ipc.RpcServer$Connection.close() might ignore java.lang.Exception
Bug type DE_MIGHT_IGNORE (click for details) 
In class org.apache.hadoop.hbase.ipc.RpcServer$Connection
In method org.apache.hadoop.hbase.ipc.RpcServer$Connection.close()
Exception class java.lang.Exception
At RpcServer.java:[line 1920]
At RpcServer.java:[line 1920]

And I haven't touched this file.

It says - 

./hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java:602:5:
error: Method length is 174 lines (max allowed is 150).

and it's line is 14 chars long.

2 out of 3 tests are passing for me, TestStoreFileInfo is genuine, will fix in next patch.

> Add metrics for storefile age
> -----------------------------
>
>                 Key: HBASE-15135
>                 URL: https://issues.apache.org/jira/browse/HBASE-15135
>             Project: HBase
>          Issue Type: New Feature
>            Reporter: Elliott Clark
>            Assignee: Mikhail Antonov
>         Attachments: HBASE-15135.patch
>
>
> In order to make sure that compactions are fully up to date it would be nice to have
metrics on:
> * Max storefile age
> * Min storefile age
> * Average storefile age
> * Number of reference files
> If we could have those metrics per region and per regionserver it would be awesome.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message