hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15125) HBaseFsck's adoptHdfsOrphan function creates region with wrong end key boundary
Date Thu, 21 Jan 2016 07:36:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15110223#comment-15110223
] 

Anoop Sam John commented on HBASE-15125:
----------------------------------------

bq.The most important we got the correct region infos,like below,
It may be because of the initial region boundaries and the data that was present in the missing
region's HFiles.  My point was that , for the new region, we found the max of the rk in all
HFiles under that and added \x00 byte.    What if in files we were not having a real max possible
rk under this region? Say that region was actually [a, d) and the max rk in files is 'b' 
So we will create the new region as [a, c\x00)  Now there is a hole created [cx00, d)..  
Not sure whether subsequent steps in HBCK checks and correct it. Am I making it clear?
To say it clearly this is not directly related to ur patch.  

> HBaseFsck's adoptHdfsOrphan function creates region with wrong end key boundary
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-15125
>                 URL: https://issues.apache.org/jira/browse/HBASE-15125
>             Project: HBase
>          Issue Type: Bug
>          Components: hbck
>    Affects Versions: 2.0.0
>            Reporter: chenrongwei
>            Assignee: chenrongwei
>         Attachments: HBASE-15125-V001.patch, HBASE-15125-v002.patch, HBASE-15125-v003.patch,
HBASE-15125-v004.patch
>
>
> There is a bug in HBaseFsck's adoptHdfsOrphan function.At the last of this function will
create a region,which want to cover all the orphan regions.But the end key of this new region
was set incorrectly.Correct region's boundary should be [startKey,endKey),but this function
create a region with boundary of [startKey,endKey],this bug will leads to scan operation omit
some data.
> I think we should create the region like bellow,
>     // create new region on hdfs. move data into place.
>     HRegionInfo hri = new HRegionInfo(template.getTableName(), orphanRegionRange.getFirst(),
>         Bytes.add(orphanRegionRange.getSecond(), new byte[1]));



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message