hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15117) Resolve ICAST findbugs warnings in current codes
Date Fri, 15 Jan 2016 19:28:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15102346#comment-15102346
] 

Hudson commented on HBASE-15117:
--------------------------------

FAILURE: Integrated in HBase-Trunk_matrix #635 (See [https://builds.apache.org/job/HBase-Trunk_matrix/635/])
HBASE-15117 Resolve ICAST findbugs warnings in current codes (Yu Li) (stack: rev cb17c7a97a1e2eb0ebd532f614191e4edbb9e49b)
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/Compactor.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/ExportSnapshot.java


> Resolve ICAST findbugs warnings in current codes
> ------------------------------------------------
>
>                 Key: HBASE-15117
>                 URL: https://issues.apache.org/jira/browse/HBASE-15117
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Yu Li
>            Assignee: Yu Li
>            Priority: Minor
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15117.patch
>
>
> In [findbugs output|https://builds.apache.org/job/PreCommit-HBASE-Build/120/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html#Warnings_STYLE]
of recent build, we could see ICAST warnings (Result of integer multiplication cast to long)
on Compactor and ExportSnapshot
> From the code I guess the design is to avoid multiplication result to overflow, however
current implementation cannot achieve the goal. For example, output of below codes
> {code}
> int i = 1000000;
> long a = i * i;
> long b = (long) i * i;
> System.out.println(a);
> System.out.println(b);
> {code}
> will be
> {noformat}
> -727379968
> 1000000000000
> {noformat}
> Will make some minor changes to resolve this issue.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message