hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Helmling (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15111) "hbase version" should write to stdout
Date Thu, 14 Jan 2016 18:03:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098524#comment-15098524
] 

Gary Helmling commented on HBASE-15111:
---------------------------------------

Just to note, since the VersionInfo output is no longer going through a logger, it does changes
the output text slightly, as it no longer contains the normal log line prefixing.

Old output is:
{noformat}
[gmh-mbp ~/devel/hbase (master)]$ ./bin/hbase version
2016-01-14 09:54:55,558 INFO  [main] util.VersionInfo: HBase 2.0.0-SNAPSHOT
2016-01-14 09:54:55,558 INFO  [main] util.VersionInfo: Source code repository git://gmh-mbp/home/gmh/devel/hbase
revision=dc57996ca6d52b48c7f274956c0deca513ea7a83
2016-01-14 09:54:55,558 INFO  [main] util.VersionInfo: Compiled by gmh on Thu Jan 14 09:51:43
PST 2016
2016-01-14 09:54:55,558 INFO  [main] util.VersionInfo: From source with checksum 3abb2f7818240cafd5234a93abc94b8d
{noformat}

After the patch, output is:
{noformat}
[gmh-mbp ~/devel/hbase (version_stdout)]$ ./bin/hbase org.apache.hadoop.hbase.util.VersionInfo
HBase 2.0.0-SNAPSHOT
Source code repository git://gmh-mbp/home/gmh/devel/hbase revision=dc57996ca6d52b48c7f274956c0deca513ea7a83
Compiled by gmh on Thu Jan 14 09:36:43 PST 2016
>From source with checksum 79053353562fbce9dbb20eab58f4d61b
{noformat}

I consider this an improvement, but don't know if we should consider this a compatibility
issue for such a basic command.

> "hbase version" should write to stdout
> --------------------------------------
>
>                 Key: HBASE-15111
>                 URL: https://issues.apache.org/jira/browse/HBASE-15111
>             Project: HBase
>          Issue Type: Improvement
>          Components: util
>            Reporter: Gary Helmling
>            Assignee: Gary Helmling
>            Priority: Trivial
>         Attachments: hbase-15111-v1.patch
>
>
> Calling {{hbase version}} currently outputs the version info by writing to {{LOG.info}}.
 This means, if you change the default log level settings, you may get no output at all on
the command line.
> Since {{VersionInfo.main()}} is being called, it should really just output straight to
stdout.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message