hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15101) Leaked References to StoreFile.Reader after HBASE-13082
Date Tue, 19 Jan 2016 09:14:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106464#comment-15106464
] 

ramkrishna.s.vasudevan commented on HBASE-15101:
------------------------------------------------

Can you try coming up with a test case to see this problem is reproducible as an FT. Try to
start 2 region servers and after some data insertion ensure there is a major compaction and
count the number of files after the compacted discharger chore runs.
Also in your experimental set up are you seeing that none of the compacted files are are getting
finalized or few of them are getting  finalized and few are getting missed out? If nothing
is getting finalized then it would be great to check the status of those files in by adding
some debug logs in HStore.closeAndArchiveStoreFiles() (the method name am not very sure but
something like this was added which does the finalization part).

> Leaked References to StoreFile.Reader after HBASE-13082
> -------------------------------------------------------
>
>                 Key: HBASE-15101
>                 URL: https://issues.apache.org/jira/browse/HBASE-15101
>             Project: HBase
>          Issue Type: Bug
>          Components: HFile, io
>    Affects Versions: 2.0.0
>            Reporter: deepankar
>            Assignee: deepankar
>         Attachments: HBASE-15101-v1.patch, HBASE-15101-v2.patch, HBASE-15101-v3.patch,
HBASE-15101.patch
>
>
> We observed this production that after a region server dies there are huge number of
hfiles in that region for the region server running the version with HBASE-13082, In the doc
it is given that it is expected to happen, but we found a one place where scanners are not
being closed. If the scanners are not closed their references are not decremented and that
is leading to the issue of huge number of store files not being finalized
> All I was able to find is in the selectScannersFrom, where we discard some of the scanners
and we are not closing them. I am attaching a patch for that.
> Also to avoid these issues should the files that are done be logged and finalized (moved
to archive) as a part of region close operation. This will solve any leaks that can happen
and does not cause any dire consequences?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message