hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashu Pachauri (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15093) Replication can report incorrect size of log queue for the global source when multiwal is enabled
Date Wed, 27 Jan 2016 22:39:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120318#comment-15120318
] 

Ashu Pachauri commented on HBASE-15093:
---------------------------------------

{quote}
The failed tests seems relevant though.
{quote}
Sorry, I was busy with other stuff. The tests should not be directly related to this patch
and they pass on my system. Looking at the failures, it seems like all of them failed due
to timeouts. I will put another patch fixing the checkstyle issues and see if tests pass this
time. I wonder if timeouts in some of these tests are too strict!!

> Replication can report incorrect size of log queue for the global source when multiwal
is enabled
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15093
>                 URL: https://issues.apache.org/jira/browse/HBASE-15093
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 2.0.0, 1.2.0, 1.2.1
>            Reporter: Ashu Pachauri
>            Assignee: Ashu Pachauri
>            Priority: Minor
>         Attachments: HBASE-15093-V0.patch
>
>
> Replication can  report incorrect size for the size of log queue for the global source
when multiwal is enabled. This happens because the method MetricsSource#setSizeofLogQueue
performs non-trivial operations in a multithreaded world, even though it is not synchronized.

> We can simply divide MetricsSource#setSizeofLogQueue into MetricsSource#incrSizeofLogQueue
and MetricsSource#decrSizeofLogQueue. Not sure why we are currently directly setting the size
instead of incrementing/decrementing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message