hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Enis Soztutar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15093) Replication can report incorrect size of log queue for the global source when multiwal is enabled
Date Wed, 20 Jan 2016 02:18:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15107836#comment-15107836
] 

Enis Soztutar commented on HBASE-15093:
---------------------------------------

The patch looks good to me. Is this something you've observed or theoretical? 

> Replication can report incorrect size of log queue for the global source when multiwal
is enabled
> -------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-15093
>                 URL: https://issues.apache.org/jira/browse/HBASE-15093
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 2.0.0, 1.2.0, 1.2.1
>            Reporter: Ashu Pachauri
>            Assignee: Ashu Pachauri
>            Priority: Minor
>         Attachments: HBASE-15093-V0.patch
>
>
> Replication can  report incorrect size for the size of log queue for the global source
when multiwal is enabled. This happens because the method MetricsSource#setSizeofLogQueue
performs non-trivial operations in a multithreaded world, even though it is not synchronized.

> We can simply divide MetricsSource#setSizeofLogQueue into MetricsSource#incrSizeofLogQueue
and MetricsSource#decrSizeofLogQueue. Not sure why we are currently directly setting the size
instead of incrementing/decrementing it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message