hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anoop Sam John (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15082) Fix merge of MVCC and SequenceID performance regression
Date Mon, 11 Jan 2016 10:49:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091760#comment-15091760
] 

Anoop Sam John commented on HBASE-15082:
----------------------------------------

bq.this.setIsolationLevel(get.getIsolationLevel());
Good catch and fix.. Can we do the same in other constructor also? Scan(Scan scan)

{code}
if (cell.getTagsLength() <= 0) return tags;
236	    Iterator<Tag> itr =
237	        CellUtil.tagsIterator(cell.getTagsArray(), cell.getTagsOffset(), cell.getTagsLength());
{code}
Suggest using CellUtil.tagsIterator(cell).  No need to add the length check also as the CellUtil
API doing it and returning a static instance of Empty iterator. So no unwanted object creation
also.

bq.((HStore)store).getHRegion().getReadPoint(IsolationLevel.READ_COMMITTED));
getReadpoint() in Region interface which is not private. Is the name change with out deprecation
is right?

HRegion#doMinibatchOperation
What is the use of mvccNum now?  I see this is being passed to applyFamilyMapToMemstore but
not assigned with any value now. Before sync() call we wait for the seqId and that should
be used to apply to cells while adding to memstore ?


> Fix merge of MVCC and SequenceID performance regression
> -------------------------------------------------------
>
>                 Key: HBASE-15082
>                 URL: https://issues.apache.org/jira/browse/HBASE-15082
>             Project: HBase
>          Issue Type: Sub-task
>          Components: Performance
>            Reporter: stack
>            Assignee: stack
>            Priority: Critical
>             Fix For: 2.0.0, 1.2.0, 1.3.0
>
>         Attachments: 15082.patch, 15082v2.patch, 15082v2.txt, 15082v3.txt, 15082v4.patch,
15082v5.patch, 15082v6.patch, 15082v7.patch
>
>
> This is general fix for increments (appends, checkAnd*) perf-regression identified in
the parent issue. HBASE-15031 has a narrow fix for branch-1.1 and branch-1.0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message