hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15080) Remove synchronized block from MasterServiceStubMaker#releaseZooKeeperWatcher()
Date Sat, 09 Jan 2016 17:01:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15090695#comment-15090695
] 

Hudson commented on HBASE-15080:
--------------------------------

SUCCESS: Integrated in HBase-0.98-matrix #284 (See [https://builds.apache.org/job/HBase-0.98-matrix/284/])
HBASE-15080 Remove synchronized block from (tedyu: rev 1f23667a827faf2bc2cc6c2ff6b14d29b733d046)
* hbase-client/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java


> Remove synchronized block from MasterServiceStubMaker#releaseZooKeeperWatcher()
> -------------------------------------------------------------------------------
>
>                 Key: HBASE-15080
>                 URL: https://issues.apache.org/jira/browse/HBASE-15080
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>             Fix For: 0.98.17
>
>         Attachments: 15080-0.98.txt
>
>
> This is a follow up to HBASE-11460
> [~elserj] found that in 0.98, the synchronized block below should have been taken out
(as was done for branch-1 +):
> {code}
>       synchronized (masterAndZKLock) {
>         if (keepAliveZookeeperUserCount.decrementAndGet() <= 0 ){
> {code}
> keepAliveZookeeperUserCount is an AtomicInteger. There is no need for the synchronized
block.
> This issue is to remove the synchronized block.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message