hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ramkrishna.s.vasudevan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15077) Support OffheapKV write in compaction with out copying data on heap
Date Thu, 07 Jan 2016 18:10:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087798#comment-15087798
] 

ramkrishna.s.vasudevan commented on HBASE-15077:
------------------------------------------------

Just was checking the patch once before shutting down. May be am missing something 
{code}

182	    if (out instanceof ByteBufferSupportedOutputStream) {
183	      ((ByteBufferSupportedOutputStream) out).write(in, offset, length);
184	    } else if (in.hasArray()) {
185	      out.write(in.array(), in.arrayOffset() + offset, length);
{code}
Now in ByteBufferSupportedDataOutputStream we again call ByteBufferUtils.copyFromBufferToStream?
Will apply patch tomorrow and check once 

> Support OffheapKV write in compaction with out copying data on heap
> -------------------------------------------------------------------
>
>                 Key: HBASE-15077
>                 URL: https://issues.apache.org/jira/browse/HBASE-15077
>             Project: HBase
>          Issue Type: Sub-task
>          Components: regionserver, Scanners
>            Reporter: Anoop Sam John
>            Assignee: Anoop Sam John
>             Fix For: 2.0.0
>
>         Attachments: HBASE-15077.patch
>
>
> HBASE-14832  is not enough to handle this.  Doing the remaining needed here.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message