hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Heng Chen (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HBASE-15071) Cleanup bypass semantic in MasterCoprocessorHost
Date Fri, 08 Jan 2016 03:09:40 GMT

     [ https://issues.apache.org/jira/browse/HBASE-15071?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Heng Chen updated HBASE-15071:
------------------------------
    Attachment: HBASE-15071.patch

Make a patch.
Now in MasterCoprocessorHost

only preMove/preBalance/preBalanceSwitch/preAssign/preUnAssign will respect 'bypass',  the
other interfaces will just ignore it. And I make some comments on relates interfaces.

On the side, preBalance/preAssign/preUnassign will be modified according 'bypass' semantic.
 Due to code compatible,  i just comment it in 'TODO'.

Any suggestions?


> Cleanup bypass semantic in MasterCoprocessorHost
> ------------------------------------------------
>
>                 Key: HBASE-15071
>                 URL: https://issues.apache.org/jira/browse/HBASE-15071
>             Project: HBase
>          Issue Type: Task
>          Components: Coprocessors
>    Affects Versions: 2.0.0
>            Reporter: stack
>            Priority: Blocker
>         Attachments: HBASE-15071.patch
>
>
> Lets decide on this one before we release 2.0.0.
> A bunch of methods in MasterCoprocessorHost on the 'pre' step allow returning true which
indicates the method invocation is not to proceed.
> Not all 'pre' steps do this. Just some.
> Seems a little arbitrary.
> How we skip out if we are not proceed with the invocation is also a little arbitrary.
> When a deleteColumn call is supposed to skip out, it returns a -1, a non-procId. If we
are to skip a balance call, we log that CP said skip and then return false to indicate the
balancer did not run (why?). Elsewhere we just exit silently. In createNamespace we used to
exit silently but HBASE-14888 just changed it so we throw a BypassCoprocessorException instead...

> Lets make them all work the same way.
> (This issue comes of chat w/ Matteo)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message