hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matteo Bertozzi (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15071) Cleanup bypass semantic in MasterCoprocessorHost
Date Tue, 05 Jan 2016 19:37:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15083635#comment-15083635
] 

Matteo Bertozzi commented on HBASE-15071:
-----------------------------------------

the bypass() documentation says
{quote}Call to indicate that the current coprocessor's return value should be used in place
of the normal HBase obtained value.{quote}
so in my opinion bypass() make sense for stuff that return a value, like the get/scanners.
bypassing an addColumn() or a createTable() probably does not make any sense. is anyone doing
its own create instead of an hbase create? how the new stuff created/added by a non hbase
will play with the rest of the system?
maybe we can just remove the bypass boolean for operation that do not make sense.

> Cleanup bypass semantic in MasterCoprocessorHost
> ------------------------------------------------
>
>                 Key: HBASE-15071
>                 URL: https://issues.apache.org/jira/browse/HBASE-15071
>             Project: HBase
>          Issue Type: Task
>          Components: Coprocessors
>    Affects Versions: 2.0.0
>            Reporter: stack
>            Priority: Blocker
>
> Lets decide on this one before we release 2.0.0.
> A bunch of methods in MasterCoprocessorHost on the 'pre' step allow returning true which
indicates the method invocation is not to proceed.
> Not all 'pre' steps do this. Just some.
> Seems a little arbitrary.
> How we skip out if we are not proceed with the invocation is also a little arbitrary.
> When a deleteColumn call is supposed to skip out, it returns a -1, a non-procId. If we
are to skip a balance call, we log that CP said skip and then return false to indicate the
balancer did not run (why?). Elsewhere we just exit silently. In createNamespace we used to
exit silently but HBASE-14888 just changed it so we throw a BypassCoprocessorException instead...

> Lets make them all work the same way.
> (This issue comes of chat w/ Matteo)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message