hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15069) Unify HFile Writer and Reader creation patterns
Date Tue, 05 Jan 2016 10:14:39 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082768#comment-15082768
] 

Hadoop QA commented on HBASE-15069:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12780497/hbase-15069.v2.patch
  against master branch at commit 9997e4ee52136a681faa825dea46bd1162d71eca.
  ATTACHMENT ID: 12780497

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:green}+1 tests included{color}.  The patch appears to include 114 new or modified
tests.

    {color:green}+1 hadoop versions{color}. The patch compiles with all supported hadoop versions
(2.4.0 2.4.1 2.5.0 2.5.1 2.5.2 2.6.0 2.6.1 2.7.0 2.7.1)

    {color:red}-1 javac{color}.  The applied patch generated 37 javac compiler warnings (more
than the master's current 35 warnings).

    {color:green}+1 protoc{color}.  The applied patch does not increase the total number of
protoc compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any warning messages.

                {color:red}-1 checkstyle{color}.  The applied patch generated new checkstyle
errors. Check build console for list of new errors.

    {color:green}+1 findbugs{color}.  The patch does not introduce any  new Findbugs (version
2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number
of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than
100:
    +    private WriterBuilder(Path p, FSDataOutputStream ostream, Configuration conf, CacheConfig
cacheConf) {
+              "Did you change hfile.format.version to read v2? This version of the software
writes v3" +
+              " hfiles only (but it can read v2 files without having to update hfile.format.version
" +
+            throw new IllegalArgumentException("Invalid HFile version " + trailer.getMajorVersion());
+  public static CachedMobFile create(FileSystem fs, Path path, Configuration conf) throws
IOException {
+ * create, instantiate a writer using {@link org.apache.hadoop.hbase.regionserver.StoreFile.WriterBuilder}
+              HFile.Reader reader = new HFile.ReaderBuilder(storeFile.getPath(), getConf()).create();

    {color:red}-1 site{color}.  The patch appears to cause mvn post-site goal to fail.

    {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.io.hfile.TestPrefetch
                  org.apache.hadoop.hbase.mob.TestMobFile
                  org.apache.hadoop.hbase.regionserver.TestStoreFile
                  org.apache.hadoop.hbase.mob.TestCachedMobFile

    {color:green}+1 zombies{color}. No zombie tests found running at the end of the build.

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/17126//testReport/
Release Findbugs (version 2.0.3) 	warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/17126//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors: https://builds.apache.org/job/PreCommit-HBASE-Build/17126//artifact/patchprocess/checkstyle-aggregate.html

                Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/17126//console

This message is automatically generated.

> Unify HFile Writer and Reader creation patterns
> -----------------------------------------------
>
>                 Key: HBASE-15069
>                 URL: https://issues.apache.org/jira/browse/HBASE-15069
>             Project: HBase
>          Issue Type: Bug
>          Components: HFile
>    Affects Versions: 2.0.0
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 2.0.0
>
>         Attachments: hbase-15069.patch, hbase-15069.v2.patch
>
>
> There are a plethora of different static methods sprinkled through out HStoreFile and
HFile, and many tests that have extraneous calls to 'new CacheConfig(conf)' or essentially
extraneous FileSystem arguments threaded through out the code.
> This patch forces all creation to go through HFile Reader and Writer Builders, eliminates
all static Builder constructors, and limits the exposure Reader/Writers .  It also forces
all HFile writer uses outside of the o.a.h.h.io.hfile package to use the StoreFile writers



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message