hbase-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HBASE-15069) Unify HFile Writer and Reader creation patterns
Date Thu, 14 Jan 2016 20:25:40 GMT

    [ https://issues.apache.org/jira/browse/HBASE-15069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15098781#comment-15098781
] 

Hadoop QA commented on HBASE-15069:
-----------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} |
{color:green} Patch does not have any anti-patterns. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green}
The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color}
| {color:green} The patch appears to include 38 new or modified test files. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 16s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 20s {color} |
{color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 34s {color} |
{color:green} master passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m 14s {color}
| {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 28s {color}
| {color:green} master passed {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 48s {color} | {color:red}
hbase-server in master has 83 extant Findbugs warnings. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 43s {color} | {color:red}
hbase-spark in master has 67 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 45s {color} |
{color:green} master passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 42s {color} |
{color:green} master passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} scaladoc {color} | {color:red} 0m 7s {color} | {color:red}
hbase-server in master failed. {color} |
| {color:red}-1{color} | {color:red} scaladoc {color} | {color:red} 0m 6s {color} | {color:red}
hbase-server in master failed. {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 47s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 20s {color} |
{color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 20s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} scalac {color} | {color:green} 1m 20s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 34s {color} |
{color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 34s {color} | {color:green}
the patch passed {color} |
| {color:green}+1{color} | {color:green} scalac {color} | {color:green} 1m 34s {color} | {color:green}
the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 4m 24s {color} | {color:red}
Patch generated 7 new checkstyle issues in hbase-server (total was 455, now 441). {color}
|
| {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 28s {color}
| {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color}
| {color:green} Patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 20m 19s {color}
| {color:green} Patch does not cause any errors with Hadoop 2.4.0 2.4.1 2.5.0 2.5.1 2.5.2
2.6.1 2.6.2 2.6.3 2.7.1. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 3s {color} | {color:red}
hbase-server introduced 1 new FindBugs issues. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 43s {color} |
{color:green} the patch passed with JDK v1.8.0 {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 43s {color} |
{color:green} the patch passed with JDK v1.7.0_79 {color} |
| {color:red}-1{color} | {color:red} scaladoc {color} | {color:red} 0m 5s {color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:red}-1{color} | {color:red} scaladoc {color} | {color:red} 0m 6s {color} | {color:red}
hbase-server in the patch failed. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 81m 24s {color} | {color:green}
hbase-server in the patch passed with JDK v1.8.0. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 54s {color} | {color:green}
hbase-spark in the patch passed with JDK v1.8.0. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 81m 43s {color} | {color:green}
hbase-server in the patch passed with JDK v1.7.0_79. {color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 1m 20s {color} | {color:green}
hbase-spark in the patch passed with JDK v1.7.0_79. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 26s {color}
| {color:green} Patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 216m 56s {color} | {color:black}
{color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:hbase-server |
|  |  Switch statement found in org.apache.hadoop.hbase.io.hfile.HFile$ReaderBuilder.create()
where one case falls through to the next case  At HFile.java:where one case falls through
to the next case  At HFile.java:[lines 582-585] |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12782138/hbase-15069.v4b.patch
|
| JIRA Issue | HBASE-15069 |
| Optional Tests |  asflicense  javac  javadoc  unit  findbugs  hadoopcheck  hbaseanti  checkstyle
 compile  scalac  scaladoc  |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep
3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh
|
| git revision | master / c8b9754 |
| findbugs | v3.0.0 |
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/118/artifact/patchprocess/branch-findbugs-hbase-server-warnings.html
|
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/118/artifact/patchprocess/branch-findbugs-hbase-spark-warnings.html
|
| scaladoc | https://builds.apache.org/job/PreCommit-HBASE-Build/118/artifact/patchprocess/branch-scaladoc-hbase-server.txt
|
| scaladoc | https://builds.apache.org/job/PreCommit-HBASE-Build/118/artifact/patchprocess/branch-scaladoc-hbase-server.txt
|
| checkstyle | https://builds.apache.org/job/PreCommit-HBASE-Build/118/artifact/patchprocess/diff-checkstyle-hbase-server.txt
|
| findbugs | https://builds.apache.org/job/PreCommit-HBASE-Build/118/artifact/patchprocess/new-findbugs-hbase-server.html
|
| scaladoc | https://builds.apache.org/job/PreCommit-HBASE-Build/118/artifact/patchprocess/patch-scaladoc-hbase-server.txt
|
| scaladoc | https://builds.apache.org/job/PreCommit-HBASE-Build/118/artifact/patchprocess/patch-scaladoc-hbase-server.txt
|
| JDK v1.7.0_79  Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/118/testReport/
|
| modules | C: hbase-server hbase-spark U: . |
| Max memory used | 190MB |
| Powered by | Apache Yetus 0.1.0   http://yetus.apache.org |
| Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/118/console |


This message was automatically generated.



> Unify HFile Writer and Reader creation patterns
> -----------------------------------------------
>
>                 Key: HBASE-15069
>                 URL: https://issues.apache.org/jira/browse/HBASE-15069
>             Project: HBase
>          Issue Type: Bug
>          Components: HFile
>    Affects Versions: 2.0.0
>            Reporter: Jonathan Hsieh
>            Assignee: Jonathan Hsieh
>             Fix For: 2.0.0
>
>         Attachments: hbase-15069.patch, hbase-15069.v2.patch, hbase-15069.v3.patch, hbase-15069.v4.patch,
hbase-15069.v4b.patch
>
>
> There are a plethora of different static methods sprinkled through out HStoreFile and
HFile, and many tests that have extraneous calls to 'new CacheConfig(conf)' or essentially
extraneous FileSystem arguments threaded through out the code.
> This patch forces all creation to go through HFile Reader and Writer Builders, eliminates
all static Builder constructors, and limits the exposure Reader/Writers .  It also forces
all HFile writer uses outside of the o.a.h.h.io.hfile package to use the StoreFile writers



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message